Always broadcast one last "tab not blocked" notification before closing a tab.

Always broadcast one last "tab not blocked" notification before closing a tab.

BUG=336386
TEST=as in bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253735

[sky, 2014-01-28 22:09:29]

LGTM - I want to ask for a test, but if all this code is moving I suppose it
isn't worth it.

[Avi (use Gerrit), 2014-01-29 04:57:02]

On 2014/01/28 22:09:29, sky wrote:
> LGTM - I want to ask for a test, but if all this code is moving I suppose it
> isn't worth it.

You're right; this needs to be tested.

[Avi (use Gerrit), 2014-01-29 20:18:52]

On 2014/01/29 04:57:02, Avi wrote:
> On 2014/01/28 22:09:29, sky wrote:
> > LGTM - I want to ask for a test, but if all this code is moving I suppose it
> > isn't worth it.
> 
> You're right; this needs to be tested.

And lots of tests crash because we now have a notification about a dead
WebContents changing state. :( Not yet sure how to handle this...

[Avi (use Gerrit), 2014-02-25 17:30:35]

On 2014/01/29 20:18:52, Avi wrote:
> On 2014/01/29 04:57:02, Avi wrote:
> > On 2014/01/28 22:09:29, sky wrote:
> > > LGTM - I want to ask for a test, but if all this code is moving I suppose
it
> > > isn't worth it.
> > 
> > You're right; this needs to be tested.
> 
> And lots of tests crash because we now have a notification about a dead
> WebContents changing state. :( Not yet sure how to handle this...

For future notes (trybot runs aren't kept forever), linux_chromeos crashes:

TabCloseTest
TabMoveTest
TabSwitchTest
SelectNone

 [0x7fd93e315cb0] <unknown>
 [0x0000009236b1] FaviconTabHelper::GetFavicon()
 [0x000000f1eaa7] BrowserTabStripController::SetTabRendererDataFromModel()
 [0x000000f1eed0] BrowserTabStripController::SetTabDataAt()
 [0x000000eb1711] TabStripModel::SetTabBlocked()
 [0x000000eb404b] TabStripModel::DetachWebContentsAt()
 [0x000000eb7032] TabStripModel::WebContentsData::WebContentsDestroyed()
 [0x7fd93eec6d48] content::WebContentsImpl::~WebContentsImpl()
 [0x7fd93eec6ff9] content::WebContentsImpl::~WebContentsImpl()
 [0x000000eb18e3] TabStripModel::InternalCloseTab()

Everyone assumes that a tab state change means the WebContents is still alive.
This change is clearly not safe to make.

[Avi (use Gerrit), 2014-02-26 20:28:58]

Scott, WDYT, can you look at this again?

[sky, 2014-02-26 21:42:03]

SLGTM

[Avi (use Gerrit), 2014-02-26 22:06:21]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-02-26 22:07:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/132103005/60001

[commit-bot: I haz the power, 2014-02-27 00:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-27 00:16:38]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Avi (use Gerrit), 2014-02-27 00:18:49]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-02-27 00:22:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/132103005/60001

[commit-bot: I haz the power, 2014-02-27 06:09:40]

Change committed as 253735