Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 132103005: Always broadcast one last "tab not blocked" notification before closing a tab. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: InternalCloseTab Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tabs/tab_strip_model.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc
index dfad932240f11a5d7e939b29bdf33403f933d6e0..17b6d2ed91287d1ef02b3770e96eb7c821035884 100644
--- a/chrome/browser/ui/tabs/tab_strip_model.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model.cc
@@ -1250,6 +1250,12 @@ bool TabStripModel::InternalCloseTabs(const std::vector<int>& indices,
void TabStripModel::InternalCloseTab(WebContents* contents,
int index,
bool create_historical_tabs) {
+ // Reset the blocked state of the tab, and fire a notification if necessary.
+ // <http://crbug.com/336386#c4> . TODO(avi): Remove all the "blocked" code and
+ // the WebContentsModalDialogManager from TabStripModel, and move all that
+ // tracking code to the modal dialog code, where it belongs.
+ SetTabBlocked(index, false);
+
FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
TabClosingAt(this, contents, index));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698