Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1320863005: Skip a few checks temporarily to fix an EventSender bug. (Closed)

Created:
5 years, 3 months ago by mustaq
Modified:
5 years, 3 months ago
Reviewers:
tkent, tdresser
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Skip a few checks temporarily to fix an EventSender bug. We will fix the removed expectations after the chromium side change (crrev.com/1317733006) is in. BUG=529807 Committed: https://crrev.com/eeab2900e89b7f45d312b285f5283628aa55a85c git-svn-id: svn://svn.chromium.org/blink/trunk@201985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/fast/events/pointerevents/touch-pointer-events.html View 1 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-pointer-events-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mustaq
ptal
5 years, 3 months ago (2015-09-09 15:36:16 UTC) #2
mustaq
5 years, 3 months ago (2015-09-09 16:01:05 UTC) #4
tdresser
On 2015/09/09 16:01:05, mustaq wrote: I think the title here is wrong.
5 years, 3 months ago (2015-09-09 16:27:12 UTC) #5
mustaq
On 2015/09/09 16:27:12, tdresser wrote: > On 2015/09/09 16:01:05, mustaq wrote: > > I think ...
5 years, 3 months ago (2015-09-09 16:52:21 UTC) #6
tdresser
LGTM with nit. https://codereview.chromium.org/1320863005/diff/1/LayoutTests/fast/events/pointerevents/touch-pointer-events.html File LayoutTests/fast/events/pointerevents/touch-pointer-events.html (right): https://codereview.chromium.org/1320863005/diff/1/LayoutTests/fast/events/pointerevents/touch-pointer-events.html#newcode137 LayoutTests/fast/events/pointerevents/touch-pointer-events.html:137: //crbug.com/529807: Uncomment this after committing crrev.com/1317733006. ...
5 years, 3 months ago (2015-09-09 16:53:26 UTC) #7
mustaq
https://codereview.chromium.org/1320863005/diff/1/LayoutTests/fast/events/pointerevents/touch-pointer-events.html File LayoutTests/fast/events/pointerevents/touch-pointer-events.html (right): https://codereview.chromium.org/1320863005/diff/1/LayoutTests/fast/events/pointerevents/touch-pointer-events.html#newcode137 LayoutTests/fast/events/pointerevents/touch-pointer-events.html:137: //crbug.com/529807: Uncomment this after committing crrev.com/1317733006. On 2015/09/09 16:53:26, ...
5 years, 3 months ago (2015-09-09 17:03:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320863005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320863005/20001
5 years, 3 months ago (2015-09-09 17:04:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201985
5 years, 3 months ago (2015-09-09 18:00:09 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:00:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eeab2900e89b7f45d312b285f5283628aa55a85c

Powered by Google App Engine
This is Rietveld 408576698