Chromium Code Reviews Chromium Code Reviews
Issue 1320863005:
Skip a few checks temporarily to fix an EventSender bug. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <script src="../../../resources/js-test.js"></script> | 2 <script src="../../../resources/js-test.js"></script> |
| 3 <style> | 3 <style> |
| 4 div { | 4 div { |
| 5 margin: 10px; | 5 margin: 10px; |
| 6 padding: 50px; | 6 padding: 50px; |
| 7 float: left; | 7 float: left; |
| 8 } | 8 } |
| 9 #console { | 9 #console { |
| 10 padding: 0px; | 10 padding: 0px; |
| (...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 127 | 127 |
| 128 eventSender.updateTouchPoint(0, x+10, y+10); | 128 eventSender.updateTouchPoint(0, x+10, y+10); |
| 129 eventSender.touchMove(); | 129 eventSender.touchMove(); |
| 130 shouldBeFalse("receivedPEsAtTarget[4].isPrimary"); | 130 shouldBeFalse("receivedPEsAtTarget[4].isPrimary"); |
| 131 shouldBeEqualToNumber("receivedPEsAtTarget[4].pointerId", idSecond); | 131 shouldBeEqualToNumber("receivedPEsAtTarget[4].pointerId", idSecond); |
| 132 | 132 |
| 133 eventSender.addTouchPoint(x, y); | 133 eventSender.addTouchPoint(x, y); |
| 134 eventSender.touchStart(); | 134 eventSender.touchStart(); |
| 135 shouldBeFalse("receivedPEsAtTarget[5].isPrimary"); | 135 shouldBeFalse("receivedPEsAtTarget[5].isPrimary"); |
| 136 var idThird = receivedPEsAtTarget[5].pointerId; | 136 var idThird = receivedPEsAtTarget[5].pointerId; |
| 137 debug("receivedPEsAtTarget[5].pointerId=" + idThird) | 137 //crbug.com/529807: Uncomment this after committing crrev.com/1317733006. |
|
tdresser
2015/09/09 16:53:26
Might as well use our "TODO(mustaq):" notation her
mustaq
2015/09/09 17:03:26
Done.
| |
| 138 //debug("receivedPEsAtTarget[5].pointerId=" + idThird) | |
| 138 | 139 |
| 139 eventSender.releaseTouchPoint(0); | 140 eventSender.releaseTouchPoint(0); |
| 140 eventSender.touchEnd(); | 141 eventSender.touchEnd(); |
| 141 shouldBeFalse("receivedPEsAtTarget[6].isPrimary"); | 142 shouldBeFalse("receivedPEsAtTarget[6].isPrimary"); |
| 142 shouldBeEqualToNumber("receivedPEsAtTarget[6].pointerId", idSecond); | 143 shouldBeEqualToNumber("receivedPEsAtTarget[6].pointerId", idSecond); |
| 143 | 144 |
| 144 eventSender.releaseTouchPoint(0); | 145 eventSender.releaseTouchPoint(0); |
| 145 eventSender.touchEnd(); | 146 eventSender.touchEnd(); |
| 146 shouldBeFalse("receivedPEsAtTarget[7].isPrimary"); | 147 shouldBeFalse("receivedPEsAtTarget[7].isPrimary"); |
| 147 shouldBeEqualToNumber("receivedPEsAtTarget[7].pointerId", idThird); | 148 //crbug.com/529807: Uncomment this after committing crrev.com/1317733006. |
| 149 //shouldBeEqualToNumber("receivedPEsAtTarget[7].pointerId", idThird); | |
| 148 | 150 |
| 149 eventSender.addTouchPoint(x, y); | 151 eventSender.addTouchPoint(x, y); |
| 150 eventSender.touchStart(); | 152 eventSender.touchStart(); |
| 151 shouldBeTrue("receivedPEsAtTarget[8].isPrimary"); | 153 shouldBeTrue("receivedPEsAtTarget[8].isPrimary"); |
| 152 | 154 |
| 153 shouldBeEqualToNumber("receivedPEsAtTarget.length", 9); | 155 shouldBeEqualToNumber("receivedPEsAtTarget.length", 9); |
| 154 } | 156 } |
| 155 | 157 |
| 156 function runTests() { | 158 function runTests() { |
| 157 var rect = document.getElementById("green").getBoundingClientRect(); | 159 var rect = document.getElementById("green").getBoundingClientRect(); |
| (...skipping 24 matching lines...) Expand all Loading... | |
| 182 debug(""); | 184 debug(""); |
| 183 } | 185 } |
| 184 | 186 |
| 185 init(); | 187 init(); |
| 186 if (window.eventSender) | 188 if (window.eventSender) |
| 187 runTests(); | 189 runTests(); |
| 188 else | 190 else |
| 189 debug("This test requires eventSender"); | 191 debug("This test requires eventSender"); |
| 190 | 192 |
| 191 </script> | 193 </script> |
| OLD | NEW |
