CacheStorage: Show a warning message when unsupported CacheQueryOptions are specified

CacheStorage: Show a warning message when unsupported CacheQueryOptions are specified

Currently CacheQueryOptions(ignoreSearch, ignoreMethod, ignoreVary) are not
supported on Cache.match/matchAll/delete/keys and CacheStorage.match, but
these APIs can accept the options and just drop them internally.

This CL makes these APIs show a warning message when unsupported options
are specified.

BUG=426309, 499216, 482256, 520784
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201316

[nhiroki, 2015-08-27 03:58:39]

nhiroki@chromium.org changed reviewers:
+ jkarlin@chromium.org

[nhiroki, 2015-08-27 04:01:08]

Hi, can you review this? Thanks!

https://codereview.chromium.org/1320823003/diff/1/LayoutTests/http/tests/cach...
File LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt
(right):

https://codereview.chromium.org/1320823003/diff/1/LayoutTests/http/tests/cach...
LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt:9: PASS
Cache.match with ignoreSearch option (request with search parameter)
fyi: These ignoreSearch tests can pass regardless of 'ignoreSearch' option. I'll
fix them in a separate CL.

[jkarlin, 2015-08-27 11:29:16]

lgtm w/ nits

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
File Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
Source/modules/cachestorage/Cache.cpp:31: void
checkCacheQueryOptions(ExecutionContext* context, const CacheQueryOptions&
options)
Switch the argument order as options is an input variable and context is
arguably an output variable.

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
File Source/modules/cachestorage/CacheStorage.cpp (right):

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
Source/modules/cachestorage/CacheStorage.cpp:43: void
checkCacheQueryOptions(ExecutionContext* context, const CacheQueryOptions&
options)
switch argument order

[nhiroki, 2015-08-27 13:41:53]

Thank you!

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
File Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
Source/modules/cachestorage/Cache.cpp:31: void
checkCacheQueryOptions(ExecutionContext* context, const CacheQueryOptions&
options)
On 2015/08/27 11:29:15, jkarlin wrote:
> Switch the argument order as options is an input variable and context is
> arguably an output variable.

Done.

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
File Source/modules/cachestorage/CacheStorage.cpp (right):

https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage...
Source/modules/cachestorage/CacheStorage.cpp:43: void
checkCacheQueryOptions(ExecutionContext* context, const CacheQueryOptions&
options)
On 2015/08/27 11:29:15, jkarlin wrote:
> switch argument order

Done.

[nhiroki, 2015-08-27 13:41:58]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-08-27 13:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/1320823003/#ps20001
(title: "swap arguments")

[commit-bot: I haz the power, 2015-08-27 13:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320823003/20001

[commit-bot: I haz the power, 2015-08-27 14:46:56]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201316