Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 1320823003: CacheStorage: Show a warning message when unsupported CacheQueryOptions are specified (Closed)

Created:
3 years, 9 months ago by nhiroki
Modified:
3 years, 9 months ago
Reviewers:
jkarlin
CC:
blink-reviews, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CacheStorage: Show a warning message when unsupported CacheQueryOptions are specified Currently CacheQueryOptions(ignoreSearch, ignoreMethod, ignoreVary) are not supported on Cache.match/matchAll/delete/keys and CacheStorage.match, but these APIs can accept the options and just drop them internally. This CL makes these APIs show a warning message when unsupported options are specified. BUG=426309, 499216, 482256, 520784 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201316

Patch Set 1 #

Total comments: 5

Patch Set 2 : swap arguments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/window/cache-matchAll-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/worker/cache-match-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/worker/cache-matchAll-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/cachestorage/Cache.cpp View 1 6 chunks +15 lines, -0 lines 0 comments Download
M Source/modules/cachestorage/CacheStorage.cpp View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nhiroki
Hi, can you review this? Thanks! https://codereview.chromium.org/1320823003/diff/1/LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt File LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt (right): https://codereview.chromium.org/1320823003/diff/1/LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt#newcode9 LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt:9: PASS Cache.match with ...
3 years, 9 months ago (2015-08-27 04:01:08 UTC) #2
jkarlin
lgtm w/ nits https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage/Cache.cpp File Source/modules/cachestorage/Cache.cpp (right): https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage/Cache.cpp#newcode31 Source/modules/cachestorage/Cache.cpp:31: void checkCacheQueryOptions(ExecutionContext* context, const CacheQueryOptions& options) ...
3 years, 9 months ago (2015-08-27 11:29:16 UTC) #3
nhiroki
Thank you! https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage/Cache.cpp File Source/modules/cachestorage/Cache.cpp (right): https://codereview.chromium.org/1320823003/diff/1/Source/modules/cachestorage/Cache.cpp#newcode31 Source/modules/cachestorage/Cache.cpp:31: void checkCacheQueryOptions(ExecutionContext* context, const CacheQueryOptions& options) On ...
3 years, 9 months ago (2015-08-27 13:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320823003/20001
3 years, 9 months ago (2015-08-27 13:42:05 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2015-08-27 14:46:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201316

Powered by Google App Engine
This is Rietveld 408576698