Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 132073002: Fix end_to_end_test performance regression caused by using mutexes (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Noam Samuel
Visibility:
Public.

Description

Fix end_to_end_test performance regression caused by using mutexes instead of notifications in server_thread. Testing only. Merge internal change: 59322530 Reversed pause/resume changes of server_thread in the following CL: https://codereview.chromium.org/127503002/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -38 lines) Patch
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.h View 3 chunks +14 lines, -8 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 3 chunks +33 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-09 16:29:19 UTC) #1
Ryan Hamilton
LGTM. Are you going to include this in your "merge QUIC changes" CL?
6 years, 11 months ago (2014-01-09 16:36:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/132073002/1
6 years, 11 months ago (2014-01-09 16:45:35 UTC) #3
ramant (doing other things)
On 2014/01/09 16:36:19, Ryan Hamilton wrote: > LGTM. Are you going to include this in ...
6 years, 11 months ago (2014-01-09 16:46:40 UTC) #4
Ryan Hamilton
On 2014/01/09 16:46:40, ramant wrote: > On 2014/01/09 16:36:19, Ryan Hamilton wrote: > > LGTM. ...
6 years, 11 months ago (2014-01-09 16:55:24 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 19:13:13 UTC) #6
Message was sent while issue was closed.
Change committed as 243948

Powered by Google App Engine
This is Rietveld 408576698