Issue 1320683002: Write sources from flattenhtml to depfiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320683002: Write sources from flattenhtml to depfiles. (Closed)

Created:
5 years, 3 months ago by brettw

Modified:
5 years, 3 months ago

Reviewers:
Dan Beam

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Write sources from flattenhtml to depfiles. Previously, only explicit inputs were written to depfiles. This patch adds any includes in files marked "flattenhtml=true" which are also dependencies of the .grd file. BUG=http://crbug.com/519860

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	grit/node/misc.py	View		1 chunk	+8 lines, -2 lines	0 comments	Download
	M	grit/node/misc_unittest.py	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dan Beam

lgtm but I'm still confused as to how this worked for GYP but not GN...

5 years, 3 months ago (2015-08-26 17:35:03 UTC) #3

brettw

5 years, 3 months ago (2015-08-26 17:41:46 UTC) #4

GYP uses a different code path for getting the input files that doesn't involve
writing depfiles. The code GYP calls is in tools/grit/grit_info.py.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages