Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320673011: Minor code cleanup (left over from prior CL) (Closed)

Created:
5 years, 3 months ago by robertphillips
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor code cleanup (left over from prior CL) This was requested in https://codereview.chromium.org/1309543012/ (Add new GM to directly exercise perspective bitmap drawing) Committed: https://skia.googlesource.com/skia/+/943a462fef57832e2683894bb9f2f36ac25d98f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -233 lines) Patch
M gm/bitmapsource.cpp View 2 chunks +6 lines, -19 lines 0 comments Download
M gm/displacement.cpp View 3 chunks +17 lines, -39 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 4 chunks +10 lines, -15 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 3 chunks +6 lines, -20 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 3 chunks +12 lines, -16 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M gm/lighting.cpp View 4 chunks +7 lines, -20 lines 0 comments Download
M gm/lightingshader.cpp View 2 chunks +5 lines, -13 lines 0 comments Download
M gm/matrixconvolution.cpp View 4 chunks +12 lines, -13 lines 0 comments Download
M gm/offsetimagefilter.cpp View 3 chunks +8 lines, -19 lines 0 comments Download
M gm/perspshaders.cpp View 2 chunks +3 lines, -10 lines 0 comments Download
M gm/repeated_bitmap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +6 lines, -22 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 2 chunks +6 lines, -19 lines 0 comments Download
M tools/sk_tool_utils.h View 2 chunks +10 lines, -2 lines 0 comments Download
M tools/sk_tool_utils.cpp View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 3 months ago (2015-09-03 19:55:52 UTC) #2
joshualitt
On 2015/09/03 19:55:52, robertphillips wrote: lgtm
5 years, 3 months ago (2015-09-03 19:59:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320673011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320673011/1
5 years, 3 months ago (2015-09-03 20:08:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-03 20:13:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320673011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320673011/1
5 years, 3 months ago (2015-09-03 20:31:56 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 20:32:37 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/943a462fef57832e2683894bb9f2f36ac25d98f7

Powered by Google App Engine
This is Rietveld 408576698