Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1320613003: media: Remove SkCanvasVideoRenderer cache invalidation. (Closed)

Created:
5 years, 3 months ago by Daniele Castagna
Modified:
5 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove SkCanvasVideoRenderer cache invalidation. When VideoFrame carries one native texture, with a GL_TEXTURE_2D target, we assumed we could avoid caching the created SkImage, since we just used the texture directly for drawing. Unfortunately if we're drawing to a software canvas we need to read the pixels back from the texture, and that is expensive. Keeping the same SkImage allows Skia to cache the expensive operation. BUG=521531 Committed: https://crrev.com/771b5cf7667def96ba3de5cb4a4bf38cff12c3b4 Cr-Commit-Position: refs/heads/master@{#345799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M media/blink/skcanvas_video_renderer.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Daniele Castagna
5 years, 3 months ago (2015-08-26 17:12:00 UTC) #2
DaleCurtis
lgtm
5 years, 3 months ago (2015-08-27 01:27:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320613003/1
5 years, 3 months ago (2015-08-27 03:03:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 04:53:42 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 04:54:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/771b5cf7667def96ba3de5cb4a4bf38cff12c3b4
Cr-Commit-Position: refs/heads/master@{#345799}

Powered by Google App Engine
This is Rietveld 408576698