Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: media/blink/skcanvas_video_renderer.cc

Issue 1320613003: media: Remove SkCanvasVideoRenderer cache invalidation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/skcanvas_video_renderer.cc
diff --git a/media/blink/skcanvas_video_renderer.cc b/media/blink/skcanvas_video_renderer.cc
index 41e1a968ccf0684e50e7bb15ba57c1fc4170c3a7..bd628a5176eeec3f0992901cdc6442dd1c577a5d 100644
--- a/media/blink/skcanvas_video_renderer.cc
+++ b/media/blink/skcanvas_video_renderer.cc
@@ -127,12 +127,6 @@ skia::RefPtr<SkImage> NewSkImageFromVideoFrameYUVTextures(
return skia::AdoptRef(img);
}
-bool ShouldCacheVideoFrameSkImage(const VideoFrame* video_frame) {
- return !video_frame->HasTextures() ||
- media::VideoFrame::NumPlanes(video_frame->format()) != 1 ||
- video_frame->mailbox_holder(0).texture_target != GL_TEXTURE_2D;
-}
-
// Creates a SkImage from a |video_frame| backed by native resources.
// The SkImage will take ownership of the underlying resource.
skia::RefPtr<SkImage> NewSkImageFromVideoFrameNative(
@@ -388,9 +382,6 @@ void SkCanvasVideoRenderer::Paint(const scoped_refptr<VideoFrame>& video_frame,
// Make sure to flush so we can remove the videoframe from the generator.
canvas->flush();
- if (!ShouldCacheVideoFrameSkImage(video_frame.get()))
- ResetCache();
-
if (video_frame->HasTextures()) {
DCHECK(gl);
SyncPointClientImpl client(gl);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698