Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: cc/base/worker_pool.cc

Issue 13206004: cc: Fix build issues for adding ‘chromium_code’: 1 to cc.gyp and cc_tests.gyp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/base/worker_pool.cc
diff --git a/cc/base/worker_pool.cc b/cc/base/worker_pool.cc
index d2765292ddfd8e6e267ffd30864dc2189c903fcd..60cce5336e750876d6406810df78d5d90f837cd6 100644
--- a/cc/base/worker_pool.cc
+++ b/cc/base/worker_pool.cc
@@ -191,9 +191,9 @@ WorkerPool::Inner::~Inner() {
// Cancel all pending callbacks.
weak_ptr_factory_.InvalidateWeakPtrs();
- DCHECK_EQ(pending_tasks_.size(), 0);
- DCHECK_EQ(completed_tasks_.size(), 0);
- DCHECK_EQ(running_task_count_, 0);
+ DCHECK(pending_tasks_.empty());
jamesr 2013/03/29 00:07:16 one slight bummer about this change is if the DCHE
danakj 2013/03/29 00:17:35 True.. okay I'll switch all these to == 0
+ DCHECK(completed_tasks_.empty());
+ DCHECK_EQ(running_task_count_, 0u);
}
void WorkerPool::Inner::Shutdown() {
@@ -430,7 +430,7 @@ WorkerPool::~WorkerPool() {
// Cancel all pending callbacks.
weak_ptr_factory_.InvalidateWeakPtrs();
- DCHECK_EQ(completed_tasks_.size(), 0);
+ DCHECK(completed_tasks_.empty());
jamesr 2013/03/29 00:07:16 ditto
}
void WorkerPool::Shutdown() {

Powered by Google App Engine
This is Rietveld 408576698