cc: Fix build issues for adding ‘chromium_code’: 1 to cc.gyp and cc_tests.gyp

cc/base/worker_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/base/worker_pool.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
@@ skipping 173 matching lines @@
 }
 
 WorkerPool::Inner::~Inner() {
   base::AutoLock lock(lock_);
 
   DCHECK(shutdown_);
 
   // Cancel all pending callbacks.
   weak_ptr_factory_.InvalidateWeakPtrs();
 
-  DCHECK_EQ(pending_tasks_.size(), 0);
-  DCHECK_EQ(completed_tasks_.size(), 0);
-  DCHECK_EQ(running_task_count_, 0);
+  DCHECK(pending_tasks_.empty());

[jamesr, 2013/03/29 00:07:16]

one slight bummer about this change is if the DCHECK fails this won't print out
the actual size. can you change it to DCHECK_EQ(..., 0u)?

[danakj, 2013/03/29 00:17:35]

True.. okay I'll switch all these to == 0

+  DCHECK(completed_tasks_.empty());
+  DCHECK_EQ(running_task_count_, 0u);
 }
 
 void WorkerPool::Inner::Shutdown() {
   {
     base::AutoLock lock(lock_);
 
     DCHECK(!shutdown_);
     shutdown_ = true;
 
     // Wake up a worker so it knows it should exit. This will cause all workers
@@ skipping 216 matching lines @@
                      // for completed tasks delay is 0.
                      check_for_completed_tasks_delay == base::TimeDelta()))) {
 }
 
 WorkerPool::~WorkerPool() {
   Shutdown();
 
   // Cancel all pending callbacks.
   weak_ptr_factory_.InvalidateWeakPtrs();
 
-  DCHECK_EQ(completed_tasks_.size(), 0);
+  DCHECK(completed_tasks_.empty());

[jamesr, 2013/03/29 00:07:16]

ditto

 }
 
 void WorkerPool::Shutdown() {
   inner_->Shutdown();
   DispatchCompletionCallbacks();
 }
 
 void WorkerPool::PostTaskAndReply(
     const Callback& task, const base::Closure& reply) {
   PostTask(make_scoped_ptr(new WorkerPoolTaskImpl(
@@ skipping 120 matching lines @@
                          TRACE_EVENT_SCOPE_THREAD);
     CancelCheckForCompletedTasks();
     DispatchCompletionCallbacks();
     // Schedule another check for completed tasks if not idle.
     if (!is_idle)
       ScheduleCheckForCompletedTasks();
   }
 }
 
 }  // namespace cc