Rename isBlock() to isEnclosingBlock() in EditingUtilities

Rename isBlock() to isEnclosingBlock() in EditingUtilities

This patch renames |isBlock(Node*)| to |isEnclosingBlock(Node*)| to make
meaning of function cleaner for improving readability.

This is follow up patch of http://crrev.com/1309903003, which introduces
|enclosingNodeOfType()|, which uses |isBlock()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201261

[yosin_UTC9, 2015-08-26 06:27:50]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-08-26 07:16:45]

PTAL

[hajimehoshi, 2015-08-26 07:21:48]

lgtm

https://codereview.chromium.org/1320573003/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1320573003/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilities.cpp:644: return enclosingNode &&
enclosingNode->isElementNode() ? toElement(enclosingNode) : 0;
nit: nullptr

[yosin_UTC9, 2015-08-26 07:35:54]

Thanks!

https://codereview.chromium.org/1320573003/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1320573003/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilities.cpp:644: return enclosingNode &&
enclosingNode->isElementNode() ? toElement(enclosingNode) : 0;
On 2015/08/26 07:21:48, hajimehoshi wrote:
> nit: nullptr

Done.

[yosin_UTC9, 2015-08-26 07:35:56]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-26 07:35:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
hajimehoshi@chromium.org
Link to the patchset: https://codereview.chromium.org/1320573003/#ps20001
(title: "2015-08-26T16:34:56　Follow review commands: s/0/nullptr/")

[commit-bot: I haz the power, 2015-08-26 07:36:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320573003/20001

[commit-bot: I haz the power, 2015-08-26 09:35:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 09:35:13]

Failed to apply patch for Source/core/editing/EditingUtilities.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/EditingUtilities.h
  Hunk #1 FAILED at 129.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/editing/EditingUtilities.h.rej

Patch:       Source/core/editing/EditingUtilities.h
Index: Source/core/editing/EditingUtilities.h
diff --git a/Source/core/editing/EditingUtilities.h
b/Source/core/editing/EditingUtilities.h
index
9a9866bef17a312042e8f86a72fc3ee1401bae94..2db1b80db56ce1f7fbefbbd1ec5a7a3d89cf3685
100644
--- a/Source/core/editing/EditingUtilities.h
+++ b/Source/core/editing/EditingUtilities.h
@@ -129,7 +129,7 @@ inline bool canHaveChildrenForEditing(const Node* node)
 }
 
 bool isAtomicNode(const Node*);
-CORE_EXPORT bool isBlock(const Node*);
+CORE_EXPORT bool isEnclosingBlock(const Node*);
 bool isInline(const Node*);
 bool isTabHTMLSpanElement(const Node*);
 bool isTabHTMLSpanElementTextNode(const Node*);

[yosin_UTC9, 2015-08-26 09:47:48]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-26 09:47:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320573003/20001

[commit-bot: I haz the power, 2015-08-26 09:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 09:53:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2015-08-26 12:49:12]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-26 12:49:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
hajimehoshi@chromium.org
Link to the patchset: https://codereview.chromium.org/1320573003/#ps40001
(title: "2015-08-26T21:48:03 Rebase")

[commit-bot: I haz the power, 2015-08-26 12:49:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320573003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320573003/40001

[commit-bot: I haz the power, 2015-08-26 16:29:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 16:29:54]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2015-08-26 22:52:17]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-26 22:52:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320573003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320573003/40001

[commit-bot: I haz the power, 2015-08-26 23:51:46]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201261