Source/core/editing/commands/InsertListCommand.cpp - Issue 1320573003: Rename isBlock() to isEnclosingBlock() in EditingUtilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/InsertListCommand.cpp

Issue 1320573003: Rename isBlock() to isEnclosingBlock() in EditingUtilities (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-26T21:48:03 Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/commands/FormatBlockCommand.cpp ('k') | Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/commands/InsertListCommand.cpp

diff --git a/Source/core/editing/commands/InsertListCommand.cpp b/Source/core/editing/commands/InsertListCommand.cpp

index 74a0b91109d4a6c557bc77488227df08528b195f..65286dd52140b6883d2b38cc67cf99c519275415 100644

--- a/Source/core/editing/commands/InsertListCommand.cpp

+++ b/Source/core/editing/commands/InsertListCommand.cpp

@@ -381,7 +381,7 @@ PassRefPtrWillBeRawPtr<HTMLElement> InsertListCommand::listifyParagraph(const Vi

listElement = createHTMLElement(document(), listTag);

appendNode(listItemElement, listElement);

- if (start.deepEquivalent() == end.deepEquivalent() && isBlock(start.deepEquivalent().anchorNode())) {

+ if (start.deepEquivalent() == end.deepEquivalent() && isEnclosingBlock(start.deepEquivalent().anchorNode())) {

// Inserting the list into an empty paragraph that isn't held open

// by a br or a '\n', will invalidate start and end. Insert

// a placeholder and then recompute start and end.

« no previous file with comments | « Source/core/editing/commands/FormatBlockCommand.cpp ('k') | Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »