Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Unified Diff: Source/modules/cachestorage/CacheStorage.h

Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: revert unrelated unit test addition Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/cachestorage/CacheStorage.h
diff --git a/Source/modules/cachestorage/CacheStorage.h b/Source/modules/cachestorage/CacheStorage.h
index 117c39a62592fec934a42abba3a3913a14c76020..bb7e2315b1f4db078518603a6f922eb0e39dfdf0 100644
--- a/Source/modules/cachestorage/CacheStorage.h
+++ b/Source/modules/cachestorage/CacheStorage.h
@@ -25,7 +25,7 @@ class CacheStorage final : public GarbageCollectedFinalized<CacheStorage>, publi
DEFINE_WRAPPERTYPEINFO();
WTF_MAKE_NONCOPYABLE(CacheStorage);
public:
- static CacheStorage* create(WeakPtr<GlobalFetch::ScopedFetcher>, WebServiceWorkerCacheStorage*);
+ static CacheStorage* create(WeakPtrWillBeRawPtr<GlobalFetch::ScopedFetcher>, WebServiceWorkerCacheStorage*);
~CacheStorage();
void dispose();
@@ -47,10 +47,10 @@ private:
friend class WithCacheCallbacks;
friend class DeleteCallbacks;
- CacheStorage(WeakPtr<GlobalFetch::ScopedFetcher>, PassOwnPtr<WebServiceWorkerCacheStorage>);
+ CacheStorage(WeakPtrWillBeRawPtr<GlobalFetch::ScopedFetcher>, PassOwnPtr<WebServiceWorkerCacheStorage>);
ScriptPromise matchImpl(ScriptState*, const Request*, const CacheQueryOptions&);
- WeakPtr<GlobalFetch::ScopedFetcher> m_scopedFetcher;
+ WeakPtrWillBeMember<GlobalFetch::ScopedFetcher> m_scopedFetcher;
haraken 2015/08/27 00:41:05 Ditto. Can the WeakPtr be a RawPtr in non-oilpan?
OwnPtr<WebServiceWorkerCacheStorage> m_webCacheStorage;
HeapHashMap<String, Member<Cache>> m_nameToCacheMap;
};

Powered by Google App Engine
This is Rietveld 408576698