Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: Source/modules/cachestorage/CacheStorage.cpp

Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: revert unrelated unit test addition Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/cachestorage/CacheStorage.cpp
diff --git a/Source/modules/cachestorage/CacheStorage.cpp b/Source/modules/cachestorage/CacheStorage.cpp
index f6f4f0cf1280f7fe18b2dca35884369da1e59589..d2b3d3c22033dba11f8009032eefe1a88750d917 100644
--- a/Source/modules/cachestorage/CacheStorage.cpp
+++ b/Source/modules/cachestorage/CacheStorage.cpp
@@ -203,7 +203,7 @@ private:
Persistent<ScriptPromiseResolver> m_resolver;
};
-CacheStorage* CacheStorage::create(WeakPtr<GlobalFetch::ScopedFetcher> fetcher, WebServiceWorkerCacheStorage* webCacheStorage)
+CacheStorage* CacheStorage::create(WeakPtrWillBeRawPtr<GlobalFetch::ScopedFetcher> fetcher, WebServiceWorkerCacheStorage* webCacheStorage)
{
return new CacheStorage(fetcher, adoptPtr(webCacheStorage));
}
@@ -313,7 +313,7 @@ ScriptPromise CacheStorage::matchImpl(ScriptState* scriptState, const Request* r
return promise;
}
-CacheStorage::CacheStorage(WeakPtr<GlobalFetch::ScopedFetcher> fetcher, PassOwnPtr<WebServiceWorkerCacheStorage> webCacheStorage)
+CacheStorage::CacheStorage(WeakPtrWillBeRawPtr<GlobalFetch::ScopedFetcher> fetcher, PassOwnPtr<WebServiceWorkerCacheStorage> webCacheStorage)
: m_scopedFetcher(fetcher)
, m_webCacheStorage(webCacheStorage)
{
@@ -330,6 +330,7 @@ void CacheStorage::dispose()
DEFINE_TRACE(CacheStorage)
{
+ visitor->trace(m_scopedFetcher);
visitor->trace(m_nameToCacheMap);
}

Powered by Google App Engine
This is Rietveld 408576698