LayoutObject::adjustStyleDifference doesn't check backgroundColor when repainting

LayoutObject::adjustStyleDifference doesn't check backgroundColor when repainting

'background: currentColor' not getting repainted when 'color' is changed. 
LayoutObject::adjustStyleDifference doesn't check backgroundColor when
repainting. The related bug filed occurs only on Chrome. Both FF and IE
deal with this correctly.

BUG=487489
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201378

[nainar1, 2015-08-26 02:35:55]

nainar@google.com changed reviewers:
+ nainar@google.com, timloh@chromium.org

[nainar1, 2015-08-26 02:35:56]

Tim,

Could you please take a look?

[nainar1, 2015-08-26 03:46:02]

nainar@google.com changed reviewers:
- nainar@google.com

[nainar1, 2015-08-28 03:21:09]

nainar@google.com changed reviewers:
+ nainar@google.com

[nainar1, 2015-08-28 03:21:10]

TIm,

Could you take a look at the new patch set?

[nainar1, 2015-08-28 03:21:43]

nainar@google.com changed reviewers:
- nainar@google.com

[Timothy Loh, 2015-08-28 04:48:44]

lgtm

https://codereview.chromium.org/1320553004/diff/40001/LayoutTests/fast/repain...
File LayoutTests/fast/repaint/background-currentColor-repaint.html (right):

https://codereview.chromium.org/1320553004/diff/40001/LayoutTests/fast/repain...
LayoutTests/fast/repaint/background-currentColor-repaint.html:5: #input1 {
input is a weird name..

I would've written:

div {
 (width, height, background)
}

#div1 { color: blue; }
#div2 { color: transparent; }

https://codereview.chromium.org/1320553004/diff/40001/Source/core/layout/Layo...
File Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/1320553004/diff/40001/Source/core/layout/Layo...
Source/core/layout/LayoutObject.cpp:1693: if (!isText() && (!hasLayer() ||
!toLayoutBoxModelObject(this)->layer()->hasStyleDeterminedDirectCompositingReasons()))
{
Don't add unrelated changes like these, it just makes it harder to blame these
lines in the future.

[nainar1, 2015-08-28 05:02:40]

nainar@google.com changed reviewers:
+ nainar@google.com

[nainar1, 2015-08-28 05:02:40]

Final edits made. Landing

https://codereview.chromium.org/1320553004/diff/40001/LayoutTests/fast/repain...
File LayoutTests/fast/repaint/background-currentColor-repaint.html (right):

https://codereview.chromium.org/1320553004/diff/40001/LayoutTests/fast/repain...
LayoutTests/fast/repaint/background-currentColor-repaint.html:5: #input1 {
Done

https://codereview.chromium.org/1320553004/diff/40001/Source/core/layout/Layo...
File Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/1320553004/diff/40001/Source/core/layout/Layo...
Source/core/layout/LayoutObject.cpp:1693: if (!isText() && (!hasLayer() ||
!toLayoutBoxModelObject(this)->layer()->hasStyleDeterminedDirectCompositingReasons()))
{
Done

[nainar1, 2015-08-28 05:02:48]

nainar@google.com changed reviewers:
- nainar@google.com

[nainar1, 2015-08-28 05:03:00]

The CQ bit was checked by nainar@google.com

[nainar1, 2015-08-28 05:03:00]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1320553004/#ps60001
(title: "Final edits")

[commit-bot: I haz the power, 2015-08-28 05:03:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320553004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320553004/60001

[nainar1, 2015-08-28 05:26:11]

The CQ bit was unchecked by nainar@google.com

[nainar1, 2015-08-28 05:30:08]

The CQ bit was checked by nainar@google.com

[nainar1, 2015-08-28 05:30:08]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1320553004/#ps80001
(title: "Improving code styling")

[commit-bot: I haz the power, 2015-08-28 05:30:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320553004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320553004/80001

[nainar1, 2015-08-28 05:30:21]

nainar@google.com changed reviewers:
- nainar@google.com

[commit-bot: I haz the power, 2015-08-28 06:56:23]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201378