Source/core/layout/LayoutObject.cpp - Issue 1320553004: LayoutObject::adjustStyleDifference doesn't check backgroundColor when repainting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1320553004: LayoutObject::adjustStyleDifference doesn't check backgroundColor when repainting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improving code styling Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutObject.cpp

diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp

index 6ddea1c970ff66b203ede634690f88b51eb529ca..87b741d89e6be117c746a085fbc7e02f58295d20 100644

--- a/Source/core/layout/LayoutObject.cpp

+++ b/Source/core/layout/LayoutObject.cpp

@@ -1703,6 +1703,7 @@ StyleDifference LayoutObject::adjustStyleDifference(StyleDifference diff) const

if (diff.textOrColorChanged() && !diff.needsPaintInvalidation()) {

if (style()->hasBorder() || style()->hasOutline()

+ || style()->isBackgroundColorCurrentColor()

|| (isText() && !toLayoutText(this)->isAllCollapsibleWhitespace()))

diff.setNeedsPaintInvalidationObject();

}

« no previous file with comments | « LayoutTests/fast/repaint/background-currentColor-repaint-expected.txt ('k') | Source/core/style/ComputedStyle.h » ('j') | no next file with comments »