Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1320543006: Remove touch scroll chaining from main thread scrolling. (Closed)

Created:
5 years, 3 months ago by tdresser
Modified:
5 years, 2 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@gclient
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove touch scroll chaining from main thread scrolling. This leaves a bunch of potential cleanup, but we'll see whether or not we want to stick with this before performing it. BUG=526462 Committed: https://crrev.com/20e1ede5e6eb73dac71b026a8d76da195048145a Cr-Commit-Position: refs/heads/master@{#351351}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve test coverage. #

Patch Set 3 : Fix scroll customization tests. #

Patch Set 4 : Fix silly mistake in mac expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -826 lines) Patch
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-past-extent.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-past-extent-diagonally.html View 1 2 1 chunk +18 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-past-extent-diagonally-expected.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-past-extent-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html View 1 2 1 chunk +0 lines, -144 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-propagated-diagonally.html View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-propagated-diagonally-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-propagated-expected.txt View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-twice-past-extent.html View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-twice-past-extent-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html View 1 2 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated-expected.txt View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-past-extent.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-past-extent-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html View 1 2 1 chunk +0 lines, -123 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated-expected.txt View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field.html View 1 2 4 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox-expected.txt View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-past-extent.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-past-extent-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html View 1 2 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-propagated-expected.txt View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/touch-scroll-customization.html View 1 2 2 chunks +7 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/events/touch/gesture/touch-gesture-scroll-input-field-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/events/touch/gesture/touch-gesture-scroll-listbox-expected.txt View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformGestureEvent.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tdresser
This appears to be enough for the main thread case. See https://codereview.chromium.org/1306193006/ for the compositor ...
5 years, 3 months ago (2015-09-03 18:08:53 UTC) #2
Rick Byers
Nit: BUG # is wrong Nit: Please update subject / description to clarify that this ...
5 years, 3 months ago (2015-09-03 19:55:10 UTC) #3
tdresser
I've added a bit more test coverage. This is currently failing the scroll customization tests ...
5 years, 3 months ago (2015-09-09 13:47:06 UTC) #4
Rick Byers
Still LGTM
5 years, 2 months ago (2015-09-25 16:46:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320543006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320543006/60001
5 years, 2 months ago (2015-09-29 16:47:29 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-29 18:06:15 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 18:07:00 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/20e1ede5e6eb73dac71b026a8d76da195048145a
Cr-Commit-Position: refs/heads/master@{#351351}

Powered by Google App Engine
This is Rietveld 408576698