third_party/WebKit/Source/platform/PlatformGestureEvent.h - Issue 1320543006: Remove touch scroll chaining from main thread scrolling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/PlatformGestureEvent.h

Issue 1320543006: Remove touch scroll chaining from main thread scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@gclient

Patch Set: Fix silly mistake in mac expectations. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/mac/fast/events/touch/gesture/touch-gesture-scroll-listbox-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/PlatformGestureEvent.h

diff --git a/third_party/WebKit/Source/platform/PlatformGestureEvent.h b/third_party/WebKit/Source/platform/PlatformGestureEvent.h

index 53453a186462f593f6548137716175d6aa9d50ae..52fd1f3f488d98656f4c425fd6f9a2c5669cf19a 100644

--- a/third_party/WebKit/Source/platform/PlatformGestureEvent.h

+++ b/third_party/WebKit/Source/platform/PlatformGestureEvent.h

@@ -135,8 +135,11 @@ public:

bool preventPropagation() const

{

+ // TODO(tdresser) Once we've decided if we're getting rid of scroll

+ // chaining, we should remove all scroll chaining related logic. See

+ // crbug.com/526462 for details.

ASSERT(m_type == PlatformEvent::GestureScrollUpdate);

- return m_data.m_scroll.m_preventPropagation;

+ return true;

}

float scale() const