Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320513005: simplify bitmap scaler and cache (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify bitmap scaler and cache BUG=skia: Committed: https://skia.googlesource.com/skia/+/99138876a699a41637fe8c46ccdb0292dcabd7ce

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -148 lines) Patch
M src/core/SkBitmapCache.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M src/core/SkBitmapCache.cpp View 1 2 chunks +18 lines, -18 lines 0 comments Download
M src/core/SkBitmapController.cpp View 1 2 chunks +11 lines, -11 lines 0 comments Download
M src/core/SkBitmapScaler.h View 1 chunk +3 lines, -53 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 4 chunks +5 lines, -58 lines 0 comments Download
M tests/SkResourceCacheTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320513005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320513005/20001
5 years, 3 months ago (2015-08-31 21:58:23 UTC) #2
reed1
5 years, 3 months ago (2015-08-31 22:01:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 22:06:15 UTC) #6
f(malita)
lgtm https://codereview.chromium.org/1320513005/diff/20001/src/core/SkBitmapCache.h File src/core/SkBitmapCache.h (right): https://codereview.chromium.org/1320513005/diff/20001/src/core/SkBitmapCache.h#newcode30 src/core/SkBitmapCache.h:30: * Search based on the src bitmap and ...
5 years, 3 months ago (2015-08-31 22:08:12 UTC) #7
reed1
https://codereview.chromium.org/1320513005/diff/20001/src/core/SkBitmapCache.h File src/core/SkBitmapCache.h (right): https://codereview.chromium.org/1320513005/diff/20001/src/core/SkBitmapCache.h#newcode30 src/core/SkBitmapCache.h:30: * Search based on the src bitmap and inverse ...
5 years, 3 months ago (2015-08-31 22:11:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320513005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320513005/40001
5 years, 3 months ago (2015-08-31 22:11:25 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 22:16:20 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/99138876a699a41637fe8c46ccdb0292dcabd7ce

Powered by Google App Engine
This is Rietveld 408576698