Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1320473002: Reland of ix zero-length tangent (Closed)

Created:
5 years, 3 months ago by caryclark
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of ix zero-length tangent (patchset #1 id:1 of https://codereview.chromium.org/1312243002/ ) Reason for revert: Layout suppression has landed, and verified that Skia gm test changes are correct. Original issue's description: > Revert of fix zero-length tangent (patchset #2 id:20001 of https://codereview.chromium.org/1311273002/ ) > > Reason for revert: > causes layout test to draw differently -- new drawing is more correct. Reverting until layout test ignore is landed. > > Original issue's description: > > fix zero-length tangent > > > > If the end point and the control point are the same, computing > > the tangent will result in (0, 0). In this case, use the prior > > control point instead. > > > > R=reed@google.com > > > > BUG=skia:4191 > > > > Committed: https://skia.googlesource.com/skia/+/7544124fb8ee744f68f549a353f8a9163cd7432d > > TBR=reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4191 > > Committed: https://skia.googlesource.com/skia/+/91298b47c547b2ab4697038c04685af957bd1416 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4191 Committed: https://skia.googlesource.com/skia/+/45398dff710c6cdadbc3c686faa7bf692febd222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -19 lines) Patch
M gm/strokes.cpp View 2 chunks +56 lines, -0 lines 0 comments Download
M src/core/SkGeometry.cpp View 7 chunks +30 lines, -19 lines 0 comments Download
M tests/GeometryTest.cpp View 2 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
Created Reland of ix zero-length tangent
5 years, 3 months ago (2015-08-25 20:18:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320473002/1
5 years, 3 months ago (2015-08-25 20:18:59 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 20:19:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/45398dff710c6cdadbc3c686faa7bf692febd222

Powered by Google App Engine
This is Rietveld 408576698