Issue 132043002: Rename WebCore::ScrollBehavior to ScrollAlignmentBehavior

Issue 132043002: Rename WebCore::ScrollBehavior to ScrollAlignmentBehavior (Closed)

Created:
6 years, 11 months ago by ajuma

Modified:
6 years, 11 months ago

Reviewers:
Ian Vollick, jamesr

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename WebCore::ScrollBehavior to ScrollAlignmentBehavior ScrollBehavior is the most logical type name for the value of the new scroll-behavior CSS property (http://www.w3.org/TR/2013/WD-cssom-view-20131217/#css-properties). This CL renames the existing ScrollBehavior type (which is only referenced in two files) to ScrollAlignmentBehavior. This also renames ScrollBehavior.h to ScrollAlignment.h, since the main thing declared in this file is the ScrollAlignment struct. BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164796

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase and fix another #inlcude #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -272 lines)			Patch
M	Source/core/core.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/FrameSelection.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderObject.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/core/rendering/ScrollAlignment.h	View		2 chunks	+17 lines, -17 lines	0 comments	Download
A +	Source/core/rendering/ScrollAlignment.cpp	View		5 chunks	+22 lines, -22 lines	0 comments	Download
D	Source/core/rendering/ScrollBehavior.h	View		1 chunk	+0 lines, -83 lines	0 comments	Download
D	Source/core/rendering/ScrollBehavior.cpp	View		1 chunk	+0 lines, -146 lines	0 comments	Download
M	Source/web/TextFinder.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ajuma

https://codereview.chromium.org/132043002/diff/1/Source/core/rendering/ScrollAlignment.h File Source/core/rendering/ScrollAlignment.h (right): https://codereview.chromium.org/132043002/diff/1/Source/core/rendering/ScrollAlignment.h#newcode56 Source/core/rendering/ScrollAlignment.h:56: ScrollAlignmentClosestEdge These values needed to be renamed since their ...

6 years, 11 months ago (2014-01-09 16:31:10 UTC) #1

Ian Vollick

On 2014/01/09 16:31:10, ajuma wrote: > https://codereview.chromium.org/132043002/diff/1/Source/core/rendering/ScrollAlignment.h > File Source/core/rendering/ScrollAlignment.h (right): > > https://codereview.chromium.org/132043002/diff/1/Source/core/rendering/ScrollAlignment.h#newcode56 > ...

6 years, 11 months ago (2014-01-09 17:51:55 UTC) #2

ajuma

On 2014/01/09 17:51:55, Ian Vollick wrote: > lgtm, but I'm not an OWNER in source/web/ ...

6 years, 11 months ago (2014-01-09 17:54:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/132043002/60001

6 years, 11 months ago (2014-01-09 19:12:27 UTC) #5

Message was sent while issue was closed.

Change committed as 164796

Expand Messages | Collapse Messages