Add new termination status for failed launch

chrome/browser/metrics/chrome_stability_metrics_provider.cc

Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc
diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
index a26d263d3f6913906dcaef38f4e92358f05fdc64..6b5927cb8264fe9af72592aea2ef0b33043df039 100644
--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc
+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
@@ -14,6 +14,7 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_result_codes.h"
 #include "chrome/common/pref_names.h"
 #include "components/metrics/proto/system_profile.pb.h"
 #include "content/public/browser/child_process_data.h"
@@ -66,7 +67,6 @@ int MapCrashExitCodeForHistogram(int exit_code) {
   if (exit_code == STATUS_GUARD_PAGE_VIOLATION)
     return 0x1FCF7EC3;  // Randomly picked number.
 #endif
-

[Alexei Svitkine (slow), 2015/08/31 19:06:14]

Nit: Remove spurious change.

[Will Harris, 2015/09/01 01:15:38]

Done.

   return std::abs(exit_code);
 }
 
@@ -310,7 +310,16 @@ void ChromeStabilityMetricsProvider::LogRendererCrash(
   } else if (status == base::TERMINATION_STATUS_STILL_RUNNING) {
     UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.DisconnectedAlive",
                              was_extension_process ? 2 : 1);
+  } else if (status == base::TERMINATION_STATUS_LAUNCH_FAILED) {
+    UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildLaunchFailures",
+                             was_extension_process ? 2 : 1);

[Alexei Svitkine (slow), 2015/08/31 19:06:14]

Hmm, this macro shouldn't be using UMA_HISTOGRAM_PERCENTAGE - it doesn't seem to
be logging a percent. It should likely be UMA_HISTOGRAM_ENUMERATION().

The one above should be fixed up too - as well as the ones in
cast_stability_metrics_provider.cc.

[Will Harris, 2015/09/01 01:15:38]

Done.

+    // Treat child process launch as a crash for now.
+    if (was_extension_process)
+      IncrementPrefValue(prefs::kStabilityExtensionRendererCrashCount);
+    else
+      IncrementPrefValue(prefs::kStabilityRendererCrashCount);
   }
+
 }
 
 void ChromeStabilityMetricsProvider::LogRendererHang() {