Add new termination status for failed launch

chrome/browser/metrics/chrome_stability_metrics_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_result_codes.h"
 #include "chrome/common/pref_names.h"
 #include "components/metrics/proto/system_profile.pb.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 
 #if defined(ENABLE_EXTENSIONS)
 #include "extensions/browser/process_map.h"
@@ skipping 32 matching lines @@
 // Converts an exit code into something that can be inserted into our
 // histograms (which expect non-negative numbers less than MAX_INT).
 int MapCrashExitCodeForHistogram(int exit_code) {
 #if defined(OS_WIN)
   // Since |abs(STATUS_GUARD_PAGE_VIOLATION) == MAX_INT| it causes problems in
   // histograms.cc. Solve this by remapping it to a smaller value, which
   // hopefully doesn't conflict with other codes.
   if (exit_code == STATUS_GUARD_PAGE_VIOLATION)
     return 0x1FCF7EC3;  // Randomly picked number.
 #endif
-

[Alexei Svitkine (slow), 2015/08/31 19:06:14]

Nit: Remove spurious change.

[Will Harris, 2015/09/01 01:15:38]

Done.

   return std::abs(exit_code);
 }
 
 #if defined(OS_WIN)
 void CountBrowserCrashDumpAttempts() {
   enum Outcome {
     OUTCOME_SUCCESS,
     OUTCOME_FAILURE,
     OUTCOME_UNKNOWN,
     OUTCOME_MAX_VALUE
@@ skipping 223 matching lines @@
                               was_extension_process ? 2 : 1,
                               3);
     memory::RecordMemoryStats(
         was_extension_process
             ? memory::RECORD_MEMORY_STATS_EXTENSIONS_OOM_KILLED
             : memory::RECORD_MEMORY_STATS_CONTENTS_OOM_KILLED);
 #endif
   } else if (status == base::TERMINATION_STATUS_STILL_RUNNING) {
     UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.DisconnectedAlive",
                              was_extension_process ? 2 : 1);
+  } else if (status == base::TERMINATION_STATUS_LAUNCH_FAILED) {
+    UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildLaunchFailures",
+                             was_extension_process ? 2 : 1);

[Alexei Svitkine (slow), 2015/08/31 19:06:14]

Hmm, this macro shouldn't be using UMA_HISTOGRAM_PERCENTAGE - it doesn't seem to
be logging a percent. It should likely be UMA_HISTOGRAM_ENUMERATION().

The one above should be fixed up too - as well as the ones in
cast_stability_metrics_provider.cc.

[Will Harris, 2015/09/01 01:15:38]

Done.

+    // Treat child process launch as a crash for now.
+    if (was_extension_process)
+      IncrementPrefValue(prefs::kStabilityExtensionRendererCrashCount);
+    else
+      IncrementPrefValue(prefs::kStabilityRendererCrashCount);
   }
+
 }
 
 void ChromeStabilityMetricsProvider::LogRendererHang() {
   IncrementPrefValue(prefs::kStabilityRendererHangCount);
 }