Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2810)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 1320093005: Mac: Don't replace "quotes" with “smartquotes” in the Omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
index f8228b3e7a4b809b77f2a0616300f0ca361b21e9..14839ea0042476c5005a18e584b830b9a21c9e1d 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
@@ -59,10 +59,12 @@ BOOL ThePasteboardIsTooDamnBig() {
// These checks seem inappropriate to the omnibox, and also
// unlikely to work reliably due to our autocomplete interfering.
//
- // Also see <http://crbug.com/173405>.
+ // Also see http://crbug.com/173405 and http://crbug.com/528014.
NSTextCheckingTypes checkingTypes = [self enabledTextCheckingTypes];
checkingTypes &= ~NSTextCheckingTypeReplacement;
checkingTypes &= ~NSTextCheckingTypeCorrection;
+ checkingTypes &= ~NSTextCheckingTypeQuote;
+ checkingTypes &= ~NSTextCheckingTypeDash;
Scott Hess - ex-Googler 2015/09/09 15:55:04 I support going for broke and disabling all intrus
Robert Sesek 2015/09/09 22:38:25 I'm OK with this, too, though. I don't feel strong
groby-ooo-7-16 2015/09/12 00:53:46 FWIW, Safari lets you pick which substitutions you
[self setEnabledTextCheckingTypes:checkingTypes];
}
return self;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698