Mac: Don't replace "quotes" with “smartquotes” in the Omnibox

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"  // IDC_*
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 41 matching lines @@
 
 - (id)initWithFrame:(NSRect)frameRect {
   if ((self = [super initWithFrame:frameRect])) {
     dropHandler_.reset([[URLDropTargetHandler alloc] initWithView:self]);
 
     forbiddenCharacters_.reset([[NSCharacterSet controlCharacterSet] retain]);
 
     // These checks seem inappropriate to the omnibox, and also
     // unlikely to work reliably due to our autocomplete interfering.
     //
-    // Also see <http://crbug.com/173405>.
+    // Also see http://crbug.com/173405 and http://crbug.com/528014.
     NSTextCheckingTypes checkingTypes = [self enabledTextCheckingTypes];
     checkingTypes &= ~NSTextCheckingTypeReplacement;
     checkingTypes &= ~NSTextCheckingTypeCorrection;
+    checkingTypes &= ~NSTextCheckingTypeQuote;
+    checkingTypes &= ~NSTextCheckingTypeDash;

[Scott Hess - ex-Googler, 2015/09/09 15:55:04]

I support going for broke and disabling all intrusive automagic changes.  I
don't know if that means setting it to 0, or &= NSTextCheckingAllTypes.

[Robert Sesek, 2015/09/09 22:38:25]

I'm OK with this, too, though. I don't feel strongly either way.

[groby-ooo-7-16, 2015/09/12 00:53:46]

FWIW, Safari lets you pick which substitutions you want. But I don't think any
should be on by default

     [self setEnabledTextCheckingTypes:checkingTypes];
   }
   return self;
 }
 
 // If the entire field is selected, drag the same data as would be
 // dragged from the field's location icon.  In some cases the textual
 // contents will not contain relevant data (for instance, "http://" is
 // stripped from URLs).
 - (BOOL)dragSelectionWithEvent:(NSEvent *)event
@@ skipping 470 matching lines @@
       [[self delegate] suggestText],
       [[self delegate] suggestColor],
       self,
       [self bounds]);
   AutocompleteTextFieldObserver* observer = [self observer];
   if (observer)
     observer->OnDidDrawRect();
 }
 
 @end