Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320013005: Make CSSParserMode parameter not optional for MutableStylePropertySet::create() (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, Rik, dglazkov+blink, dshwang, Eric Willigers, Justin Novosad, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make CSSParserMode parameter not optional for MutableStylePropertySet::create() This change makes the CSSParserMode parameter required for MutableStylePropertySet::create() instead of defaulting to HTMLQuirksMode. This makes it clearer where quirky parsing is present in the code. There are no behavioural changes in this patch. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201472

Patch Set 1 #

Total comments: 2

Patch Set 2 : -g #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M Source/core/animation/LengthStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/StringKeyframe.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/DOMWindowCSS.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/MatchResultTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/EditorCommand.cpp View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasFontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1305893005 Patch 20001

Messages

Total messages: 24 (13 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-08-28 08:42:20 UTC) #2
rune
lgtm with the extraneous g's removed. https://codereview.chromium.org/1320013005/diff/1/Source/core/editing/commands/EditorCommand.cpp File Source/core/editing/commands/EditorCommand.cpp (right): https://codereview.chromium.org/1320013005/diff/1/Source/core/editing/commands/EditorCommand.cpp#newcode123 Source/core/editing/commands/EditorCommand.cpp:123: RefPtrWillBeRawPtr<MutableStylePropertySet> style = ...
5 years, 3 months ago (2015-08-28 09:02:59 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/1320013005/diff/1/Source/core/editing/commands/EditorCommand.cpp File Source/core/editing/commands/EditorCommand.cpp (right): https://codereview.chromium.org/1320013005/diff/1/Source/core/editing/commands/EditorCommand.cpp#newcode123 Source/core/editing/commands/EditorCommand.cpp:123: RefPtrWillBeRawPtr<MutableStylePropertySet> style = MutableStylePropertySet::create(HTMLQuirksModeg); On 2015/08/28 at 09:02:59, rune ...
5 years, 3 months ago (2015-08-31 00:04:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320013005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320013005/20001
5 years, 3 months ago (2015-08-31 00:04:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/46649)
5 years, 3 months ago (2015-08-31 00:46:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320013005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320013005/20001
5 years, 3 months ago (2015-08-31 01:35:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320013005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320013005/20001
5 years, 3 months ago (2015-08-31 04:34:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320013005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320013005/40001
5 years, 3 months ago (2015-08-31 04:44:45 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/46681)
5 years, 3 months ago (2015-08-31 06:05:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320013005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320013005/40001
5 years, 3 months ago (2015-08-31 06:24:29 UTC) #23
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 07:52:17 UTC) #24
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201472

Powered by Google App Engine
This is Rietveld 408576698