Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305893005: Web Animations API: Don't allow quirky CSS values in keyframes (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Animations API: Don't allow quirky CSS values in keyframes This patch makes the use of quirky CSS values like -webkit-text color and unitless dimensions fail to parse when used in element.animate(). BUG=526921 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201524

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A LayoutTests/web-animations-api/quirky-keyframes.html View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1320013005 Patch 40001

Messages

Total messages: 15 (6 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-08-28 08:21:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305893005/1
5 years, 3 months ago (2015-08-28 08:42:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/96416)
5 years, 3 months ago (2015-08-28 09:59:08 UTC) #6
shans
Oh my yes. lgtm++
5 years, 3 months ago (2015-08-31 07:47:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305893005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305893005/20001
5 years, 3 months ago (2015-08-31 23:24:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/97501)
5 years, 3 months ago (2015-09-01 00:32:05 UTC) #11
alancutter (OOO until 2018)
Looks like we were using quirky values in Chromium code. D: https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/gallery/js/thumbnail_mode.js&q=animate%5C(%20file:%5Esrc/ui/file_manager/&sq=package:chromium&dr=C&l=721 Quirks mode also ...
5 years, 3 months ago (2015-09-01 04:50:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305893005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305893005/20001
5 years, 3 months ago (2015-09-01 06:08:58 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 06:39:28 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201524

Powered by Google App Engine
This is Rietveld 408576698