Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319993002: Remove unused earcons (Closed)

Created:
5 years, 3 months ago by dmazzoni
Modified:
5 years, 3 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@simpler_input_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused earcons BUG=491243 Committed: https://crrev.com/427f4f1490dd67cc0c1d6de815feac35a4f08a8a Cr-Commit-Position: refs/heads/master@{#346001}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Git rid of SECTION, add back ALERT_MODAL and INVALID_KEYPRESS, and renumber #

Patch Set 3 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -167 lines) Patch
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/busy_working_loop.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/collapsed.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/expanded.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/new_mail.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/object_delete.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/object_deselect.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/search_hit.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/search_miss.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/section.ogg View 1 Binary file 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_assets.gypi View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/abstract_earcons.js View 1 5 chunks +24 lines, -115 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Dependent Patchsets:

Issue 1306773003 Patch 20002
Issue 1306773003 Patch 50001

Messages

Total messages: 14 (6 generated)
dmazzoni
5 years, 3 months ago (2015-08-27 18:13:05 UTC) #2
Peter Lundblad
lgtm Please address the comments below. https://codereview.chromium.org/1319993002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js (right): https://codereview.chromium.org/1319993002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js#newcode291 chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js:291: * SECTION Did ...
5 years, 3 months ago (2015-08-27 19:35:34 UTC) #3
dmazzoni
https://codereview.chromium.org/1319993002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js (right): https://codereview.chromium.org/1319993002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js#newcode291 chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js:291: * SECTION On 2015/08/27 19:35:33, Peter Lundblad wrote: > ...
5 years, 3 months ago (2015-08-27 21:15:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319993002/20001
5 years, 3 months ago (2015-08-27 21:15:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93821)
5 years, 3 months ago (2015-08-27 21:25:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319993002/40001
5 years, 3 months ago (2015-08-27 21:42:07 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-27 22:11:29 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 22:12:09 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/427f4f1490dd67cc0c1d6de815feac35a4f08a8a
Cr-Commit-Position: refs/heads/master@{#346001}

Powered by Google App Engine
This is Rietveld 408576698