Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1319973007: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. This adds a new ToString runtime function and a fast-path ToStringStub (which is just a simple dispatcher for existing functionality), and also implements %_ToName using the ToStringStub. R=mstarzinger@chromium.org, yangguo@chromium.org BUG=v8:4307 LOG=n Committed: https://crrev.com/09de997b3504368d40644afa7310b90faff5d09c Cr-Commit-Position: refs/heads/master@{#30442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+544 lines, -25 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +34 lines, -9 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/to-string.js View 1 chunk +50 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-08-28 12:14:14 UTC) #1
Benedikt Meurer
Hey Yang, Next step to make builtins object obsolete. More to come in followup CLs. ...
5 years, 3 months ago (2015-08-28 12:15:23 UTC) #2
Yang
On 2015/08/28 12:15:23, Benedikt Meurer wrote: > Hey Yang, > > Next step to make ...
5 years, 3 months ago (2015-08-28 12:21:25 UTC) #3
Michael Starzinger
LGTM on TurboFan, didn't look at the rest.
5 years, 3 months ago (2015-08-28 12:24:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319973007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319973007/1
5 years, 3 months ago (2015-08-28 12:25:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 12:59:56 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 13:00:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09de997b3504368d40644afa7310b90faff5d09c
Cr-Commit-Position: refs/heads/master@{#30442}

Powered by Google App Engine
This is Rietveld 408576698