Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1323543002: [runtime] Replace %to_string_fun with %_ToString. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@ToStringStub
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Replace %to_string_fun with %_ToString. Introduce a new macro TO_STRING that maps to %_ToString and use that instead of calling into any of the ToString/NonStringToString JavaScript builtins. Also remove the TO_STRING_INLINE macro, which is basically obsolete with %_ToString. We still have a few uses of ToString left (via the utils export mechanism), where we need to investigate whether we will tank badly if we replace them with TO_STRING as well. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=yangguo@chromium.org BUG=v8:4307 LOG=n Committed: https://crrev.com/7a7b692b30d50daacc1d054281f723d6c2255ccf Cr-Commit-Position: refs/heads/master@{#30895}

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE. Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -176 lines) Patch
M src/array.js View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/contexts.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/date.js View 1 2 chunks +1 line, -3 lines 0 comments Download
M src/harmony-regexp.js View 1 2 chunks +1 line, -6 lines 0 comments Download
M src/i18n.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/json.js View 1 7 chunks +5 lines, -7 lines 0 comments Download
M src/macros.py View 1 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 3 chunks +2 lines, -3 lines 0 comments Download
M src/parser.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/proxy.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/runtime.js View 1 7 chunks +6 lines, -22 lines 0 comments Download
M src/runtime/runtime-date.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/runtime/runtime-json.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M src/runtime/runtime-uri.cc View 1 2 chunks +14 lines, -9 lines 0 comments Download
M src/string.js View 1 34 chunks +57 lines, -60 lines 0 comments Download
M src/string-iterator.js View 1 1 chunk +1 line, -1 line 0 comments Download
M src/symbol.js View 1 1 chunk +1 line, -1 line 0 comments Download
M src/uri.js View 1 7 chunks +8 lines, -19 lines 0 comments Download
M src/v8natives.js View 1 8 chunks +9 lines, -11 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download
D test/mjsunit/compiler/jsnatives.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/messages.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Benedikt Meurer
Hey Yang, Here's another easy... ripping out builtins one-by-one. Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-08-28 12:49:09 UTC) #2
Yang
lgtm with a comment. https://codereview.chromium.org/1323543002/diff/1/test/mjsunit/compiler/jsnatives.js File test/mjsunit/compiler/jsnatives.js (left): https://codereview.chromium.org/1323543002/diff/1/test/mjsunit/compiler/jsnatives.js#oldcode32 test/mjsunit/compiler/jsnatives.js:32: assertEquals("1", %to_string_fun(1)); IF we are ...
5 years, 3 months ago (2015-08-28 12:53:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323543002/1
5 years, 3 months ago (2015-08-28 13:02:49 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/9184)
5 years, 3 months ago (2015-08-28 13:39:58 UTC) #7
Benedikt Meurer
https://codereview.chromium.org/1323543002/diff/1/test/mjsunit/compiler/jsnatives.js File test/mjsunit/compiler/jsnatives.js (left): https://codereview.chromium.org/1323543002/diff/1/test/mjsunit/compiler/jsnatives.js#oldcode32 test/mjsunit/compiler/jsnatives.js:32: assertEquals("1", %to_string_fun(1)); Yes, we will remove ALL of them
5 years, 3 months ago (2015-08-29 16:37:48 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323543002/1
5 years, 3 months ago (2015-09-03 10:33:08 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/6259)
5 years, 3 months ago (2015-09-03 10:33:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323543002/20001
5 years, 3 months ago (2015-09-23 19:08:28 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 21:46:44 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 21:47:06 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a7b692b30d50daacc1d054281f723d6c2255ccf
Cr-Commit-Position: refs/heads/master@{#30895}

Powered by Google App Engine
This is Rietveld 408576698