Source/core/loader/FrameLoaderClient.h - Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address comments + static_cast for enum conversion Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFrameOwnerElement.cpp ('K') | « Source/core/loader/FrameFetchContextTest.cpp ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/FrameLoaderClient.h

diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h

index 4bb8b0c4abd18e9d3578d56b1cc5206127b63d65..5636e42efea1fcb2cf2e1ada0e7fad0e37d77293 100644

--- a/Source/core/loader/FrameLoaderClient.h

+++ b/Source/core/loader/FrameLoaderClient.h

@@ -132,6 +132,10 @@ public:

// Will be called when |PerformanceTiming| events are updated

virtual void didChangePerformanceTiming() { }

+ virtual void didChangeScrollingMode(Frame*, ScrollbarMode) {}

+ virtual void didChangeMarginWidth(Frame*, int) {}

+ virtual void didChangeMarginHeight(Frame*, int) {}

alexmos 2015/09/02 21:37:05 Nit: how about grouping these with didChangeName a

lazyboy 2015/09/15 01:40:33 Done.

// Transmits the change in the set of watched CSS selectors property

// that match any element on the frame.

virtual void selectorMatchChanged(const Vector<String>& addedSelectors, const Vector<String>& removedSelectors) = 0;