(blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Source/core/html/HTMLFrameOwnerElement.cpp

Index: Source/core/html/HTMLFrameOwnerElement.cpp
diff --git a/Source/core/html/HTMLFrameOwnerElement.cpp b/Source/core/html/HTMLFrameOwnerElement.cpp
index 1833cc61cb2a899e2bb4319a450b82f0a8fdb14b..cb9df157f90df8a71f2824b30d95a9c10b2b7bf3 100644
--- a/Source/core/html/HTMLFrameOwnerElement.cpp
+++ b/Source/core/html/HTMLFrameOwnerElement.cpp
@@ -108,6 +108,9 @@ HTMLFrameOwnerElement::HTMLFrameOwnerElement(const QualifiedName& tagName, Docum
     , m_contentFrame(nullptr)
     , m_widget(nullptr)
     , m_sandboxFlags(SandboxNone)
+    , m_scrollingMode(ScrollbarAuto)
+    , m_marginWidth(-1)
+    , m_marginHeight(-1)
 {
 }
 
@@ -190,6 +193,33 @@ void HTMLFrameOwnerElement::setSandboxFlags(SandboxFlags flags)
         document().frame()->loader().client()->didChangeSandboxFlags(contentFrame(), flags);
 }
 
+void HTMLFrameOwnerElement::setScrollingMode(ScrollbarMode scrollbarMode)
+{
+    m_scrollingMode = scrollbarMode;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeScrollingMode(contentFrame(), scrollbarMode);

[alexmos, 2015/09/02 21:37:05]

HTMLPlugInElement also inherits from HTMLFrameOwnerElement.  Do we need to
propagate these properties for that too, or just HTMLFrameElementBase?  If yes,
then createChildFrame needs to be fixed as well, since it currently checks
isHTMLFrameElementBase to propagate margins.

[lazyboy, 2015/09/15 01:40:32]

Since parseAttribute() in HTMLFrameElementBase was looking for these properties,
I'm guessing not. I don't see them here either:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/object
If yes,
I've made it not propagate updates if this is a plugin element.

[alexmos, 2015/09/16 00:36:47]

Acknowledged.

+}
+
+void HTMLFrameOwnerElement::setMarginWidth(int marginWidth)
+{
+    m_marginWidth = marginWidth;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginWidth(contentFrame(), m_marginWidth);
+}
+
+void HTMLFrameOwnerElement::setMarginHeight(int marginHeight)
+{
+    m_marginHeight = marginHeight;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginHeight(contentFrame(), m_marginHeight);
+}
+
 bool HTMLFrameOwnerElement::isKeyboardFocusable() const
 {
     return m_contentFrame && HTMLElement::isKeyboardFocusable();