Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319753003: Remove old blink isolate files. (Closed)

Created:
5 years, 3 months ago by joelo
Modified:
5 years, 3 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove old blink isolate files. BUG=524758 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -91 lines) Patch
D Source/platform/heap/BlinkHeapUnitTests.isolate View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/web/WebKitUnitTests.isolate View 1 chunk +0 lines, -51 lines 0 comments Download

Depends on Patchset:

Issue 1320253003 Patch 1

Messages

Total messages: 8 (2 generated)
joelo
depends on https://codereview.chromium.org/1311533007/
5 years, 3 months ago (2015-09-01 02:00:46 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-01 18:55:50 UTC) #3
haraken
LGTM
5 years, 3 months ago (2015-09-01 23:23:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319753003/1
5 years, 3 months ago (2015-09-02 01:07:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201602
5 years, 3 months ago (2015-09-02 02:53:16 UTC) #7
joelo
5 years, 3 months ago (2015-09-02 03:20:32 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1309323005/ by joelo@chromium.org.

The reason for reverting is: broke android build

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N....

Powered by Google App Engine
This is Rietveld 408576698