Add isolate/swarming support for webkit_unit_tests.

Add isolate/swarming support for webkit_unit_tests.

BUG=524758
TBR=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201586

[joelo, 2015-09-01 01:46:35]

joelo@chromium.org changed reviewers:
+ dpranke@chromium.org, maruel@chromium.org

[joelo, 2015-09-01 01:46:36]

ptal :)

[M-A Ruel, 2015-09-01 12:56:47]

https://codereview.chromium.org/1320253003/diff/1/Source/web/webkit_unit_test...
File Source/web/webkit_unit_tests.isolate (right):

https://codereview.chromium.org/1320253003/diff/1/Source/web/webkit_unit_test...
Source/web/webkit_unit_tests.isolate:48: '<(DEPTH)/testing/xvfb.py',
This should only be mapped when use_x11==1

https://codereview.chromium.org/1320253003/diff/1/Source/web/webkit_unit_test...
Source/web/webkit_unit_tests.isolate:50:
'<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
This file doesn't exist unless use_x11==11

[Dirk Pranke, 2015-09-01 18:54:18]

I defer to maruel here (I would've had the same feedback).

[Dirk Pranke, 2015-09-01 18:54:53]

On 2015/09/01 18:54:18, Dirk Pranke wrote:
> I defer to maruel here (I would've had the same feedback).

Though you should check and confirm that we actually need the X11 stuff at all;
perhaps it can just be run under the console w/ no X server?

[M-A Ruel, 2015-09-01 19:01:41]

On 2015/09/01 18:54:53, Dirk Pranke wrote:
> On 2015/09/01 18:54:18, Dirk Pranke wrote:
> > I defer to maruel here (I would've had the same feedback).
> 
> Though you should check and confirm that we actually need the X11 stuff at
all;
> perhaps it can just be run under the console w/ no X server?

Yep, I don't think x11 is needed at all.

[joelo, 2015-09-01 19:44:36]

looks like you're right again, removed the x11 stuff. ptal

https://codereview.chromium.org/1320253003/diff/1/Source/web/webkit_unit_test...
File Source/web/webkit_unit_tests.isolate (right):

https://codereview.chromium.org/1320253003/diff/1/Source/web/webkit_unit_test...
Source/web/webkit_unit_tests.isolate:48: '<(DEPTH)/testing/xvfb.py',
On 2015/09/01 12:56:47, M-A Ruel wrote:
> This should only be mapped when use_x11==1

Removed

https://codereview.chromium.org/1320253003/diff/1/Source/web/webkit_unit_test...
Source/web/webkit_unit_tests.isolate:50:
'<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
On 2015/09/01 12:56:47, M-A Ruel wrote:
> This file doesn't exist unless use_x11==11

Removed

[M-A Ruel, 2015-09-01 19:52:09]

lgtm

https://codereview.chromium.org/1320253003/diff/20001/Source/web/webkit_unit_...
File Source/web/webkit_unit_tests.isolate (right):

https://codereview.chromium.org/1320253003/diff/20001/Source/web/webkit_unit_...
Source/web/webkit_unit_tests.isolate:27: ],
spaces, not tabs

[joelo, 2015-09-01 20:00:49]

https://codereview.chromium.org/1320253003/diff/20001/Source/web/webkit_unit_...
File Source/web/webkit_unit_tests.isolate (right):

https://codereview.chromium.org/1320253003/diff/20001/Source/web/webkit_unit_...
Source/web/webkit_unit_tests.isolate:27: ],
On 2015/09/01 19:52:09, M-A Ruel wrote:
> spaces, not tabs

oops, done

[joelo, 2015-09-01 20:00:55]

The CQ bit was checked by joelo@chromium.org

[joelo, 2015-09-01 20:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1320253003/#ps40001
(title: "fix nit")

[commit-bot: I haz the power, 2015-09-01 20:01:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320253003/40001

[commit-bot: I haz the power, 2015-09-01 20:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 20:10:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[joelo, 2015-09-01 22:54:53]

dpranke@ looks like I need owners approval

[joelo, 2015-09-01 23:05:47]

The CQ bit was checked by joelo@chromium.org

[commit-bot: I haz the power, 2015-09-01 23:06:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320253003/40001

[Dirk Pranke, 2015-09-01 23:11:42]

lgtm

[commit-bot: I haz the power, 2015-09-01 23:40:04]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201586