Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1319613004: Revert of Allow default font size changing on Linux. (Closed)

Created:
5 years, 3 months ago by kochi
Modified:
5 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow default font size changing on Linux. (patchset #10 id:180001 of https://codereview.chromium.org/549303004/ ) Reason for revert: This caused a regression: https://code.google.com/p/chromium/issues/detail?id=525176 Original issue's description: > Allow default font size changing on Linux. > > Currently base rendering font size on Linux is hardcoded to 16.0 with no possibility of changing it. This patch add such possibility in RendererPreferences. > > Webkit part: https://codereview.chromium.org/570243002/ > > BUG= > > Committed: https://crrev.com/f0bc1a926d8f0326ef38b8374e42bc8e244dd2ba > Cr-Commit-Position: refs/heads/master@{#344746} TBR=jochen@chromium.org,erg@chromium.org,eseidel@chromium.org,jln@chromium.org,dmazzoni@chromium.org,plundblad@chromium.org,joleksy@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/3b1be63348b61357f9dd1905f8a012fdf10bd523 Cr-Commit-Position: refs/heads/master@{#345852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M chrome/browser/renderer_preferences_util.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow_test.unitjs View 1 chunk +1 line, -3 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/renderer_preferences.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/renderer_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_linux.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kochi
Created Revert of Allow default font size changing on Linux.
5 years, 3 months ago (2015-08-27 11:57:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319613004/1
5 years, 3 months ago (2015-08-27 11:58:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 11:58:58 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 11:59:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b1be63348b61357f9dd1905f8a012fdf10bd523
Cr-Commit-Position: refs/heads/master@{#345852}

Powered by Google App Engine
This is Rietveld 408576698