Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 13196004: Remove the extra vp8_ on the offset rule. (Closed)

Created:
7 years, 8 months ago by wwcv
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/deps/third_party/libvpx/
Visibility:
Public.

Description

Remove the extra vp8_ on the offset rule. When the file name was changed to include vp8_, the rule started prending and extra vp8_ making it vp8_vp8_asm_enc_offsets.asm This broke clean builds.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M libvpx.gyp View 7 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wwcv
Verified that the correct file is created when running the build.
7 years, 8 months ago (2013-03-29 21:18:47 UTC) #1
Alpha Left Google
LGTM.
7 years, 8 months ago (2013-03-29 21:19:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johannkoenig@chromium.org/13196004/1
7 years, 8 months ago (2013-03-29 21:20:12 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-03-29 21:20:20 UTC) #4
Message was sent while issue was closed.
Change committed as 191447

Powered by Google App Engine
This is Rietveld 408576698