Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1319543002: A batch of docs style fixes. (Closed)

Created:
5 years, 3 months ago by nodir
Modified:
4 years, 12 months ago
Reviewers:
Nico, Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A batch of docs style fixes. R=andybons@chromium.org BUG=524256 Committed: https://crrev.com/06cbaa02cafe10687a9316178528b9bb94820575 Cr-Commit-Position: refs/heads/master@{#345360}

Patch Set 1 #

Total comments: 12

Patch Set 2 : addressed comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -237 lines) Patch
M docs/tpm_quick_ref.md View 1 1 chunk +31 lines, -32 lines 0 comments Download
M docs/updating_clang.md View 1 chunk +22 lines, -9 lines 0 comments Download
M docs/updating_clang_format_binaries.md View 1 3 chunks +69 lines, -37 lines 1 comment Download
M docs/use_find_bugs_for_android.md View 1 chunk +32 lines, -15 lines 0 comments Download
M docs/useful_urls.md View 4 chunks +8 lines, -3 lines 0 comments Download
M docs/user_handle_mapping.md View 2 chunks +10 lines, -11 lines 0 comments Download
M docs/using_a_linux_chroot.md View 1 2 chunks +48 lines, -24 lines 0 comments Download
M docs/using_build_runner.md View 1 1 chunk +48 lines, -26 lines 0 comments Download
M docs/vanilla_msysgit_workflow.md View 1 chunk +105 lines, -46 lines 0 comments Download
M docs/windows_incremental_linking.md View 1 chunk +13 lines, -3 lines 0 comments Download
M docs/windows_precompiled_headers.md View 1 chunk +49 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nodir
PTAL
5 years, 3 months ago (2015-08-25 16:41:01 UTC) #1
Bons
lgtm https://codereview.chromium.org/1319543002/diff/1/docs/tpm_quick_ref.md File docs/tpm_quick_ref.md (right): https://codereview.chromium.org/1319543002/diff/1/docs/tpm_quick_ref.md#newcode11 docs/tpm_quick_ref.md:11: * [TPM ownership management(http://git.chromium.org/gitweb/?p=chromiumos/platform/cryptohome.git;a=blob;f=README.tpm) missing ] https://codereview.chromium.org/1319543002/diff/1/docs/tpm_quick_ref.md#newcode30 docs/tpm_quick_ref.md:30: ...
5 years, 3 months ago (2015-08-25 16:51:02 UTC) #2
nodir
https://codereview.chromium.org/1319543002/diff/1/docs/tpm_quick_ref.md File docs/tpm_quick_ref.md (right): https://codereview.chromium.org/1319543002/diff/1/docs/tpm_quick_ref.md#newcode11 docs/tpm_quick_ref.md:11: * [TPM ownership management(http://git.chromium.org/gitweb/?p=chromiumos/platform/cryptohome.git;a=blob;f=README.tpm) On 2015/08/25 16:51:01, Bons wrote: ...
5 years, 3 months ago (2015-08-25 17:05:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319543002/20001
5 years, 3 months ago (2015-08-25 17:06:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-25 17:15:32 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/06cbaa02cafe10687a9316178528b9bb94820575 Cr-Commit-Position: refs/heads/master@{#345360}
5 years, 3 months ago (2015-08-25 17:16:50 UTC) #8
Nico
4 years, 12 months ago (2015-12-23 01:57:55 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1319543002/diff/20001/docs/updating_clang_for...
File docs/updating_clang_format_binaries.md (right):

https://codereview.chromium.org/1319543002/diff/20001/docs/updating_clang_for...
docs/updating_clang_format_binaries.md:79: TODO: these ^^ instructions looks
odd. Are they correct???
Why do you add TODOs to instructions? This TODO doesn't add anything but
confuses the reader (and it's still around 4 months later, so you didn't intend
to do it -- and I don't know what's odd about these instructions, so I can't do
it either.)

Powered by Google App Engine
This is Rietveld 408576698