Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: docs/updating_clang.md

Issue 1319543002: A batch of docs style fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: addressed comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: docs/updating_clang.md
diff --git a/docs/updating_clang.md b/docs/updating_clang.md
index 1721dce34bb7dad1e0ee331d738ee493c20fe466..529dc2be3f1eb8566a52426da4567800f5209fd3 100644
--- a/docs/updating_clang.md
+++ b/docs/updating_clang.md
@@ -1,11 +1,24 @@
# Updating clang
- 1. Sync your Chromium tree to the latest revision to pick up any plugin changes and test the new compiler against ToT
- 1. Update clang revision in tools/clang/scripts/update.sh, upload CL to rietveld
- 1. Run tools/clang/scripts/package.py to create a tgz of the binary (mac and linux)
- 1. Do a local clobber build with that clang (mac and linux). Check that everything builds fine and no new warnings appear. (Optional if the revision picked in 1 was vetted by other means already.)
- 1. Upload the binaries using gsutil, they will appear at http://commondatastorage.googleapis.com/chromium-browser-clang/index.html
- 1. Run goma package update script to push these packages to goma, send email
- 1. `git cl try -m tryserver.chromium.mac -b mac_chromium_rel_ng -b mac_chromium_asan_rel_ng -b mac_chromium_gn_dbg -b ios_rel_device_ninja && git cl try -m tryserver.chromium.linux -b linux_chromium_gn_dbg -b linux_chromium_chromeos_dbg_ng -b linux_chromium_asan_rel_ng -b linux_chromium_chromeos_asan_rel_ng -b android_clang_dbg_recipe -b linux_chromium_trusty32_rel -b linux_chromium_rel_ng && git cl try -m tryserver.blink -b linux_blink_rel`
- 1. Commit roll CL from the first step
- 1. The bots will now pull the prebuilt binary, and goma will have a matching binary, too.
+1. Sync your Chromium tree to the latest revision to pick up any plugin
+ changes and test the new compiler against ToT
+1. Update clang revision in tools/clang/scripts/update.sh, upload CL to
+ rietveld
+1. Run tools/clang/scripts/package.py to create a tgz of the binary (mac and
+ linux)
+1. Do a local clobber build with that clang (mac and linux). Check that
+ everything builds fine and no new warnings appear. (Optional if the
+ revision picked in 1 was vetted by other means already.)
+1. Upload the binaries using gsutil, they will appear at
+ http://commondatastorage.googleapis.com/chromium-browser-clang/index.html
+1. Run goma package update script to push these packages to goma, send email
+1. `git cl try -m tryserver.chromium.mac -b mac_chromium_rel_ng -b
+ mac_chromium_asan_rel_ng -b mac_chromium_gn_dbg -b ios_rel_device_ninja &&
+ git cl try -m tryserver.chromium.linux -b linux_chromium_gn_dbg -b
+ linux_chromium_chromeos_dbg_ng -b linux_chromium_asan_rel_ng -b
+ linux_chromium_chromeos_asan_rel_ng -b android_clang_dbg_recipe -b
+ linux_chromium_trusty32_rel -b linux_chromium_rel_ng && git cl try -m
+ tryserver.blink -b linux_blink_rel`
+1. Commit roll CL from the first step
+1. The bots will now pull the prebuilt binary, and goma will have a matching
+ binary, too.

Powered by Google App Engine
This is Rietveld 408576698