Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1319473016: MediaRecorder: disabling LayoutTests in preparation of Cr CLs and a minor update (Closed)

Created:
5 years, 3 months ago by mcasas
Modified:
5 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

MediaRecorder: disabling LayoutTests in preparation of Cr CLs and a minor update Also addressing a TODO in MediaRecorder to ASSERT(). context: MediaRecorderHandler is the Cr-content class implementing MediaStream Recorder API (see below). It plugs together an existing MediaStreamVideoTrack to a new VideoTrackRecorder-WebmMuxer pair. When MSVTrack passes frames, these get encoded, muxed, and the result is sent to Blink. See DD @ https://goo.gl/vSjzC5 (*) for the plan. CL http://crrev.com/1313603004 landed MediaRecorderHandler, this one paves the way for http://crrev.com/1330873002 to land without breaking the LayoutTests, that will be updated and reenabled subsequently. (*) Used to be https://goo.gl/kreaQj BUG=262211 Committed: https://crrev.com/1162f815302a6c6a3a02974633628d41c6d58a4d git-svn-id: svn://svn.chromium.org/blink/trunk@202065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Marking MR layout tests as Skip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
D LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html View 1 3 chunks +6 lines, -2 lines 0 comments Download
D LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType.html View 1 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediarecorder/MediaRecorder.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mcasas
peter@ PTAL
5 years, 3 months ago (2015-09-10 01:40:21 UTC) #2
Peter Beverloo
On 2015/09/10 01:40:21, mcasas wrote: > peter@ PTAL Rather than renaming these files, could you ...
5 years, 3 months ago (2015-09-10 13:14:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319473016/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319473016/80001
5 years, 3 months ago (2015-09-10 16:28:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202065
5 years, 3 months ago (2015-09-10 18:42:15 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:12:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1162f815302a6c6a3a02974633628d41c6d58a4d

Powered by Google App Engine
This is Rietveld 408576698