Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Unified Diff: Source/modules/mediarecorder/MediaRecorder.cpp

Issue 1319473016: MediaRecorder: disabling LayoutTests in preparation of Cr CLs and a minor update (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Marking MR layout tests as Skip Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediarecorder/MediaRecorder.cpp
diff --git a/Source/modules/mediarecorder/MediaRecorder.cpp b/Source/modules/mediarecorder/MediaRecorder.cpp
index 3ca62ee264f1cc00fdad9cdc4ac1c5cb971ee893..7294c82e74d4b4e9dc8c7e0c627299fa0b094176 100644
--- a/Source/modules/mediarecorder/MediaRecorder.cpp
+++ b/Source/modules/mediarecorder/MediaRecorder.cpp
@@ -60,11 +60,10 @@ MediaRecorder::MediaRecorder(ExecutionContext* context, MediaStream* stream, con
, m_state(State::Inactive)
, m_dispatchScheduledEventRunner(this, &MediaRecorder::dispatchScheduledEvent)
{
- m_recorderHandler = adoptPtr(Platform::current()->createMediaRecorderHandler());
+ ASSERT(m_stream->getTracks().size());
- // TODO(mcasas): Once http://crbug.com/262211 has landed the Chromium parts,
- // and more concretetely the createMediaRecorderHandler() implementation,
- // ASSERT() here for |m_recorderHandler|.
+ m_recorderHandler = adoptPtr(Platform::current()->createMediaRecorderHandler());
+ ASSERT(m_recorderHandler);
// We deviate from the spec by not returning |UnsupportedOption|, see https://github.com/w3c/mediacapture-record/issues/18
if (!m_recorderHandler) {
« no previous file with comments | « LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698