Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: skia/ext/SkTraceMemoryDump_chrome.h

Issue 1319473003: [tracing] Add SkResourceCache statistics to chrome://tracing (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@discardable_objdumps
Patch Set: Nits. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/SkTraceMemoryDump_chrome.h
diff --git a/skia/ext/SkTraceMemoryDump_chrome.h b/skia/ext/SkTraceMemoryDump_chrome.h
new file mode 100644
index 0000000000000000000000000000000000000000..aa6f34975853f07da076d5c89c75777711b4e1c0
--- /dev/null
+++ b/skia/ext/SkTraceMemoryDump_chrome.h
@@ -0,0 +1,46 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
+#define SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
+
+#include "third_party/skia/include/core/SkTraceMemoryDump.h"
ericrk 2015/08/25 20:14:50 nit: Combine / alphabetize includes here?
+
+#include "base/macros.h"
+
+namespace base {
+namespace trace_event {
+class ProcessMemoryDump;
+}
+}
+
+namespace skia {
ericrk 2015/08/25 20:14:50 SkDiscardableMemory_Chrome isn't in a skia namespa
ssid 2015/08/25 20:43:54 um, I am not really sure, there are other files wh
ericrk 2015/08/25 20:49:56 Ok, that's fine. Let's leave this as-is. I prefer
+
+class SkTraceMemoryDump_Chrome : public SkTraceMemoryDump {
+ public:
+ SkTraceMemoryDump_Chrome(
+ base::trace_event::ProcessMemoryDump* process_memory_dump);
+ ~SkTraceMemoryDump_Chrome() override;
+
+ // SkTraceMemoryDump implementation:
+ void dumpNumericValue(const char* dumpName,
+ const char* valueName,
+ const char* units,
+ uint64_t value) override;
+ void setMemoryBacking(const char* dumpName,
+ const char* backingType,
+ const char* backingObjectId) override;
+ void setDiscardableMemoryBacking(
+ const char* dumpName,
+ const SkDiscardableMemory& discardableMemoryObject) override;
+
+ private:
+ base::trace_event::ProcessMemoryDump* process_memory_dump_;
+
+ DISALLOW_COPY_AND_ASSIGN(SkTraceMemoryDump_Chrome);
+};
+
+} // namespace skia
+
+#endif // SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_

Powered by Google App Engine
This is Rietveld 408576698