Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: skia/ext/SkTraceMemoryDump_chrome.h

Issue 1319473003: [tracing] Add SkResourceCache statistics to chrome://tracing (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@discardable_objdumps
Patch Set: Nits. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
6 #define SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
7
8 #include "third_party/skia/include/core/SkTraceMemoryDump.h"
ericrk 2015/08/25 20:14:50 nit: Combine / alphabetize includes here?
9
10 #include "base/macros.h"
11
12 namespace base {
13 namespace trace_event {
14 class ProcessMemoryDump;
15 }
16 }
17
18 namespace skia {
ericrk 2015/08/25 20:14:50 SkDiscardableMemory_Chrome isn't in a skia namespa
ssid 2015/08/25 20:43:54 um, I am not really sure, there are other files wh
ericrk 2015/08/25 20:49:56 Ok, that's fine. Let's leave this as-is. I prefer
19
20 class SkTraceMemoryDump_Chrome : public SkTraceMemoryDump {
21 public:
22 SkTraceMemoryDump_Chrome(
23 base::trace_event::ProcessMemoryDump* process_memory_dump);
24 ~SkTraceMemoryDump_Chrome() override;
25
26 // SkTraceMemoryDump implementation:
27 void dumpNumericValue(const char* dumpName,
28 const char* valueName,
29 const char* units,
30 uint64_t value) override;
31 void setMemoryBacking(const char* dumpName,
32 const char* backingType,
33 const char* backingObjectId) override;
34 void setDiscardableMemoryBacking(
35 const char* dumpName,
36 const SkDiscardableMemory& discardableMemoryObject) override;
37
38 private:
39 base::trace_event::ProcessMemoryDump* process_memory_dump_;
40
41 DISALLOW_COPY_AND_ASSIGN(SkTraceMemoryDump_Chrome);
42 };
43
44 } // namespace skia
45
46 #endif // SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698