Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1319433002:
Make selectMisspellingAsync() to use VisibleSelection::toNormalizedEphemeralRange() instead of toNor (Closed)
|
Created:
5 years, 4 months ago by yosin_UTC9 Modified:
5 years, 3 months ago CC:
blink-reviews Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionMake selectMisspellingAsync() to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()
This patch changes |selectMisspellingAsync| class to use
|toNormalizedEphemeralRange()| in |VisibleSelection| class instead of
|toNormalizedRange()| as a preparation of templatizing |VisibleSelection| to use
templatized positions instead of DOM position to represent range.
This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002
BUG=513568
TEST=n/a; no behavior changes
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201179
Patch Set 1 : 2015-08-25T15:31:59 #
Messages
Total messages: 37 (17 generated)
yosin@chromium.org changed reviewers: + hajimehoshi@chromium.org, yoichio@chromium.org
PTAL
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yosin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
yosin@chromium.org changed reviewers: + tkent@chromium.org - yosin@google.com
+tkent@ for OWNERS review
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201179 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
