Source/web/ContextMenuClientImpl.cpp - Issue 1319433002: Make selectMisspellingAsync() to use VisibleSelection::toNormalizedEphemeralRange() instead of toNor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 1319433002: Make selectMisspellingAsync() to use VisibleSelection::toNormalizedEphemeralRange() instead of toNor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-25T15:31:59 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index 8bed9cb0ba534358cb21592d00a28069b6818d07..697b4dadbb111c6a9c7ed0bd4e10f45fb087ab89 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -162,7 +162,7 @@ static String selectMisspellingAsync(LocalFrame* selectedFrame, String& descript

return String();

// Caret and range selections always return valid normalized ranges.

- RefPtrWillBeRawPtr<Range> selectionRange = selection.toNormalizedRange();

+ RefPtrWillBeRawPtr<Range> selectionRange = createRange(selection.toNormalizedEphemeralRange());

DocumentMarkerVector markers = selectedFrame->document()->markers().markersInRange(EphemeralRange(selectionRange.get()), DocumentMarker::MisspellingMarkers());

if (markers.size() != 1)

return String();

« no previous file with comments | « no previous file | no next file » | no next file with comments »