Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1319423003: Make frames.h usable without handles-inl.h header. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make frames.h usable without handles-inl.h header. This CL us a pure refactoring that makes an empty compilation unit including just "frames.h" but not "handles-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=ishell@chromium.org Committed: https://crrev.com/8ff59e8d39df3d0a76d5192cbfdb3497a17f2d04 Cr-Commit-Position: refs/heads/master@{#30476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/frames.h View 1 chunk +3 lines, -10 lines 0 comments Download
M src/frames.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-31 14:39:07 UTC) #1
Igor Sheludko
lgtm
5 years, 3 months ago (2015-08-31 14:48:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319423003/1
5 years, 3 months ago (2015-08-31 14:55:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 15:04:29 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 15:04:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ff59e8d39df3d0a76d5192cbfdb3497a17f2d04
Cr-Commit-Position: refs/heads/master@{#30476}

Powered by Google App Engine
This is Rietveld 408576698