Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 1322883002: Make isolate.h usable without objects-inl.h header. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-frames-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make isolate.h usable without objects-inl.h header. This CL us a pure refactoring that makes an empty compilation unit including just "isolate.h" or "contexts.h" but not "objects-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=bmeurer@chromium.org Committed: https://crrev.com/5f57ebe222591b1734200eedead8c21f5776ce00 Cr-Commit-Position: refs/heads/master@{#30500}

Patch Set 1 #

Patch Set 2 : Fix compilation. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -182 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/api-natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/cpu-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cancelable-task.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-node-cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/source-position.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/contexts.h View 1 2 7 chunks +28 lines, -82 lines 0 comments Download
M src/contexts.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/contexts-inl.h View 1 2 1 chunk +148 lines, -0 lines 0 comments Download
M src/debug/debug.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/extensions/free-buffer-extension.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +11 lines, -15 lines 0 comments Download
M src/factory.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/flags.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 9 chunks +18 lines, -67 lines 0 comments Download
M src/isolate.cc View 2 chunks +13 lines, -0 lines 0 comments Download
A src/isolate-inl.h View 1 chunk +104 lines, -0 lines 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/regexp-stack.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-json.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-observe.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-uri.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/string-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8threads.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
Benedikt: PTAL. Igor: Please provide "ic" OWNER review. Also, I am looking for a "regexp" ...
5 years, 3 months ago (2015-08-31 15:10:11 UTC) #1
Benedikt Meurer
> Also, I am looking for a "regexp" OWNER that is _not_ on vacation right ...
5 years, 3 months ago (2015-08-31 19:10:57 UTC) #2
Yang
On 2015/08/31 19:10:57, Benedikt Meurer wrote: > > Also, I am looking for a "regexp" ...
5 years, 3 months ago (2015-08-31 19:13:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322883002/60001
5 years, 3 months ago (2015-09-01 08:42:54 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 3 months ago (2015-09-01 09:25:25 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 09:25:37 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f57ebe222591b1734200eedead8c21f5776ce00
Cr-Commit-Position: refs/heads/master@{#30500}

Powered by Google App Engine
This is Rietveld 408576698