Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1319383002: Drop ambiguous MaybeHandle comparison and hashing ops. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-unique-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop ambiguous MaybeHandle comparison and hashing ops. The default equality comparison operators and hashing functions for Handles are ambiguous. The intended semantics might have either been based on Handle locations or on object identity. This is why such operators do not exist on Handle. The same argument applies to the MaybeHandle class as well. Comments in that regard were also added. R=bmeurer@chromium.org Committed: https://crrev.com/51fa9e5295f708495cbb3287987745eb70f3735f Cr-Commit-Position: refs/heads/master@{#30468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M src/compiler/js-operator.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/js-type-feedback-lowering.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/handles.h View 4 chunks +14 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-31 11:11:39 UTC) #1
Benedikt Meurer
LGTM
5 years, 3 months ago (2015-08-31 11:12:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319383002/1
5 years, 3 months ago (2015-08-31 11:21:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 11:37:39 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 11:37:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51fa9e5295f708495cbb3287987745eb70f3735f
Cr-Commit-Position: refs/heads/master@{#30468}

Powered by Google App Engine
This is Rietveld 408576698